From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE42FC433E7 for ; Tue, 20 Oct 2020 02:17:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73046221FC for ; Tue, 20 Oct 2020 02:17:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="oZOmX/of" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390507AbgJTCRa (ORCPT ); Mon, 19 Oct 2020 22:17:30 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:26942 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730127AbgJTCRa (ORCPT ); Mon, 19 Oct 2020 22:17:30 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603160249; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=CnNWiQS2XGA1YVaIGzFp8g14cZ1x0E0s29jTfLOsuXI=; b=oZOmX/ofedOksjD80rg3Z9EV+bL4BL+Npw4ng8yMIsChP2KBrnBjmlrqhSess1NYF1N07rDu 1sHAmhJlf5A/3mdeOw1CaL9g9/G9T9q699o6MqgHRYURudKA4+bGo57jBlP2DrrI9YwsTRSf q3IUdCasv0PT5f7cSlQGqtqX6Jo= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5f8e48b8bfed2afaa627272b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 20 Oct 2020 02:17:28 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6E0C0C43391; Tue, 20 Oct 2020 02:17:27 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id AC5BEC433FE; Tue, 20 Oct 2020 02:17:25 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 20 Oct 2020 10:17:25 +0800 From: Can Guo To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, kernel-team@android.com, Jaegeuk Kim , Alim Akhtar , Avri Altman Subject: Re: [PATCH 2/4] scsi: ufs: clear UAC for FFU and RPMB LUNs In-Reply-To: <20201005223635.2922805-2-jaegeuk@kernel.org> References: <20201005223635.2922805-1-jaegeuk@kernel.org> <20201005223635.2922805-2-jaegeuk@kernel.org> Message-ID: <3d9c3b844ac861c4cce7242e49e63059@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-10-06 06:36, Jaegeuk Kim wrote: > From: Jaegeuk Kim > > In order to conduct FFU or RPMB operations, UFS needs to clear UAC. > This patch > clears it explicitly, so that we could get no failure given early > execution. > Usually it is the user's/utility's/tool's responsiblity to clear UA by sending a request sense cmd and retry previous cmd, now we are doing it for the users in driver? As per my understanding, driver only reports UA to SCSI layer and let users decide what to do with it - maybe users need to do something specifically regs it, but the change clears it even before the users get to know it. Besides, this change clears UA for W-LUs, but the UFS driver still reports UA to SCSI layer for each SCSI device by calling scsi_report_bus_reset() in ufshcd_reset_and_restore(). This will make SCSI layer treat sdev->expecting_cc_ua wrongly, because for W-LUs, their expecting_cc_ua should not be set as you have cleared their UAs. Thanks, Can Guo. > Cc: Alim Akhtar > Cc: Avri Altman > Cc: Can Guo > Signed-off-by: Jaegeuk Kim > --- > drivers/scsi/ufs/ufshcd.c | 70 +++++++++++++++++++++++++++++++++++---- > drivers/scsi/ufs/ufshcd.h | 1 + > 2 files changed, 65 insertions(+), 6 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index d929c3d1e58cc..0bb07b50bd23e 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -6841,7 +6841,6 @@ static inline void > ufshcd_blk_pm_runtime_init(struct scsi_device *sdev) > static int ufshcd_scsi_add_wlus(struct ufs_hba *hba) > { > int ret = 0; > - struct scsi_device *sdev_rpmb; > struct scsi_device *sdev_boot; > > hba->sdev_ufs_device = __scsi_add_device(hba->host, 0, 0, > @@ -6854,14 +6853,14 @@ static int ufshcd_scsi_add_wlus(struct ufs_hba > *hba) > ufshcd_blk_pm_runtime_init(hba->sdev_ufs_device); > scsi_device_put(hba->sdev_ufs_device); > > - sdev_rpmb = __scsi_add_device(hba->host, 0, 0, > + hba->sdev_rpmb = __scsi_add_device(hba->host, 0, 0, > ufshcd_upiu_wlun_to_scsi_wlun(UFS_UPIU_RPMB_WLUN), NULL); > - if (IS_ERR(sdev_rpmb)) { > - ret = PTR_ERR(sdev_rpmb); > + if (IS_ERR(hba->sdev_rpmb)) { > + ret = PTR_ERR(hba->sdev_rpmb); > goto remove_sdev_ufs_device; > } > - ufshcd_blk_pm_runtime_init(sdev_rpmb); > - scsi_device_put(sdev_rpmb); > + ufshcd_blk_pm_runtime_init(hba->sdev_rpmb); > + scsi_device_put(hba->sdev_rpmb); > > sdev_boot = __scsi_add_device(hba->host, 0, 0, > ufshcd_upiu_wlun_to_scsi_wlun(UFS_UPIU_BOOT_WLUN), NULL); > @@ -7385,6 +7384,63 @@ static int ufshcd_add_lus(struct ufs_hba *hba) > return ret; > } > > +static int > +ufshcd_send_request_sense(struct ufs_hba *hba, struct scsi_device > *sdp); > + > +static int ufshcd_clear_ua_wlun(struct ufs_hba *hba, u8 wlun) > +{ > + struct scsi_device *sdp; > + unsigned long flags; > + int ret = 0; > + > + spin_lock_irqsave(hba->host->host_lock, flags); > + if (wlun == UFS_UPIU_UFS_DEVICE_WLUN) > + sdp = hba->sdev_ufs_device; > + else if (wlun == UFS_UPIU_RPMB_WLUN) > + sdp = hba->sdev_rpmb; > + else > + BUG_ON(1); > + if (sdp) { > + ret = scsi_device_get(sdp); > + if (!ret && !scsi_device_online(sdp)) { > + ret = -ENODEV; > + scsi_device_put(sdp); > + } > + } else { > + ret = -ENODEV; > + } > + spin_unlock_irqrestore(hba->host->host_lock, flags); > + if (ret) > + goto out_err; > + > + ret = ufshcd_send_request_sense(hba, sdp); > + scsi_device_put(sdp); > +out_err: > + if (ret) > + dev_err(hba->dev, "%s: UAC clear LU=%x ret = %d\n", > + __func__, wlun, ret); > + return ret; > +} > + > +static int ufshcd_clear_ua_wluns(struct ufs_hba *hba) > +{ > + int ret = 0; > + > + if (!hba->wlun_dev_clr_ua) > + goto out; > + > + ret = ufshcd_clear_ua_wlun(hba, UFS_UPIU_UFS_DEVICE_WLUN); > + if (!ret) > + ret = ufshcd_clear_ua_wlun(hba, UFS_UPIU_RPMB_WLUN); > + if (!ret) > + hba->wlun_dev_clr_ua = false; > +out: > + if (ret) > + dev_err(hba->dev, "%s: Failed to clear UAC WLUNS ret = %d\n", > + __func__, ret); > + return ret; > +} > + > /** > * ufshcd_probe_hba - probe hba to detect device and initialize > * @hba: per-adapter instance > @@ -7500,6 +7556,8 @@ static void ufshcd_async_scan(void *data, > async_cookie_t cookie) > pm_runtime_put_sync(hba->dev); > ufshcd_exit_clk_scaling(hba); > ufshcd_hba_exit(hba); > + } else { > + ufshcd_clear_ua_wluns(hba); > } > } > > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index 363589c0bd370..8344d8cb36786 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -662,6 +662,7 @@ struct ufs_hba { > * "UFS device" W-LU. > */ > struct scsi_device *sdev_ufs_device; > + struct scsi_device *sdev_rpmb; > > enum ufs_dev_pwr_mode curr_dev_pwr_mode; > enum uic_link_state uic_link_state;