From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F0FEC433E7 for ; Sun, 18 Oct 2020 18:27:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0391521655 for ; Sun, 18 Oct 2020 18:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727301AbgJRS1D (ORCPT ); Sun, 18 Oct 2020 14:27:03 -0400 Received: from smtprelay0035.hostedemail.com ([216.40.44.35]:40318 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727094AbgJRS1C (ORCPT ); Sun, 18 Oct 2020 14:27:02 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 6B0E9837F24A; Sun, 18 Oct 2020 18:27:01 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: dad38_590e2f027230 X-Filterd-Recvd-Size: 2921 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Sun, 18 Oct 2020 18:27:00 +0000 (UTC) Message-ID: <3d9ef962b7007308a538e42375adf09d058ee8ab.camel@perches.com> Subject: Re: [PATCH] checkpatch: Allow not using -f with files that are in git From: Joe Perches To: Geert Uytterhoeven Cc: Linus Torvalds , Andrew Morton , Andy Whitcroft , LKML Date: Sun, 18 Oct 2020 11:26:59 -0700 In-Reply-To: References: <45b81a48e1568bd0126a96f5046eb7aaae9b83c9.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-10-18 at 20:15 +0200, Geert Uytterhoeven wrote: > Hi Joe, rehi Geert > On Sun, Oct 18, 2020 at 6:07 PM Joe Perches wrote: > > On Sun, 2020-10-18 at 16:03 +0200, Geert Uytterhoeven wrote: [] > > > This is now commit f5f613259f3fea81 ("checkpatch: allow not using -f > > > with files that are in git"), causing: > > > > > > Global symbol "$gitroot" requires explicit package name (did you > > > forget to declare "my $gitroot"?) at scripts/checkpatch.pl line 980. > > > Execution of scripts/checkpatch.pl aborted due to compilation errors. [] > > I believe there is a dependency on another patch > > in -next that wasn't pushed to Linus' tree. > > > > commit 5ec1f7de97b26a3fa364bbb31fdd2e42c8e6fa22 > > Author: Joe Perches > > Date: Thu Oct 8 11:53:44 2020 +1100 > > > > checkpatch: test $GIT_DIR changes > > > > So it'd be better to revert right now until > > this other patch is accepted or pushed. > > Thanks, after cherry-picking that one from next, checkpatch works again. > However, there are some issues with that commit: > 1. ERROR: Missing Signed-off-by: line by nominal patch author 'Joe > Perches ', > 2. The Link: is bogus, and gives 404. I generally create patches against -next. The above commit was a test patch for Andrew who had some inconvenience because he doesn't generally use git or has a git repo in some non-standard path. I believe it works well enough to be OK, but I didn't test it and don't have the same setup. I'll post it again as a reply to this email with a with a sign-off and a better commit description and Linus/Andrew can decide if it's better to revert f5f613259f3f or apply it separately.