From: David Laight <David.Laight@ACULAB.COM>
To: "'Adrian Hunter'" <adrian.hunter@intel.com>,
"Christian Löhle" <CLoehle@hyperstone.com>,
"Avri Altman" <Avri.Altman@wdc.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCHv2] mmc: block: Add single read for 4k sector cards
Date: Wed, 29 Jun 2022 08:41:37 +0000 [thread overview]
Message-ID: <3d9ff280c02042e58e406241599ce893@AcuMS.aculab.com> (raw)
In-Reply-To: <e7ebb779-9938-d5f7-d900-dbea55b4ac72@intel.com>
...
> >> brq->data.blocks = queue_physical_block_size(req->q) >> SECTOR_SHIFT;
> >
> > Do we want to switch to SECTOR_SHIFT instead of 9? So far SECTOR_SHIFT is not used at all in mmc
> core.
>
> I guess '9' is more consistent
You can just multiply/divide by 512u (probably SECTOR_SIZE).
(In some senses 512u is actually better!)
More obvious still and the compiler will generate a shift anyway.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-06-29 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 9:08 [PATCHv2] mmc: block: Add single read for 4k sector cards Christian Löhle
2022-06-28 11:13 ` Adrian Hunter
2022-06-29 8:41 ` David Laight [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-24 15:29 Christian Löhle
2022-06-28 7:56 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d9ff280c02042e58e406241599ce893@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Avri.Altman@wdc.com \
--cc=CLoehle@hyperstone.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).