From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752973AbbDGHji (ORCPT ); Tue, 7 Apr 2015 03:39:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46251 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929AbbDGHjd (ORCPT ); Tue, 7 Apr 2015 03:39:33 -0400 Message-ID: <3daa9b797aa544756b9e5bea34465f10.squirrel@www.codeaurora.org> In-Reply-To: <1427812635-16617-2-git-send-email-ygardi@codeaurora.org> References: <1427812635-16617-1-git-send-email-ygardi@codeaurora.org> <1427812635-16617-2-git-send-email-ygardi@codeaurora.org> Date: Tue, 7 Apr 2015 07:39:31 -0000 Subject: Re: [PATCH v1 1/2] scsi: ufs-qcom: save controller revision info in internal structure From: "Gilad Broner" To: "Yaniv Gardi" Cc: james.bottomley@hansenpartnership.com, hch@infradead.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, ygardi@codeaurora.org, "Vinayak Holikatti" , "James E.J. Bottomley" User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Sometimes, specific information about the UFS controller revision is > required in order to determine certain operations or execute > controller dependent quirks. > In order to avoid reading the controller revision multiple times, > we simply read it once and save this information in internal structure. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 14 +++++++------- > drivers/scsi/ufs/ufs-qcom.h | 8 ++++++++ > 2 files changed, 15 insertions(+), 7 deletions(-) > Reviewed-by: Gilad Broner -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project