linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: SeongJae Park <sj38.park@gmail.com>,
	SeongJae Park <sjpark@amazon.com>,
	Brendan Higgins <brendanhiggins@google.com>
Cc: corbet@lwn.net, kunit-dev@googlegroups.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, sjpark@amazon.de,
	shuah <shuah@kernel.org>
Subject: Re: [PATCH v5 0/6] Fix nits in the kunit
Date: Wed, 11 Dec 2019 10:22:31 -0700	[thread overview]
Message-ID: <3dab421e-6aa5-90e4-791e-53482f5c1fe8@kernel.org> (raw)
In-Reply-To: <20191211163310.4788-1-sj38.park@gmail.com>

On 12/11/19 9:33 AM, SeongJae Park wrote:
> May I ask some comments?
> 
> 
> Thanks,
> SeongJae Park
> 

+ Brendan

> On Thu, 5 Dec 2019 10:34:34 +0100 SeongJae Park <sjpark@amazon.com> wrote:
> 
>>
>> This patchset contains trivial fixes for the kunit documentations and
>> the wrapper python scripts.
>>
>> This patchset is based on 'kselftest/test' branch of linux-kselftest[1]
>> and depends on Heidi's patch[2].  A complete tree is available at my repo:
>> https://github.com/sjp38/linux/tree/kunit_fix/20191205_v5
>>
>> Changes from v4
>> (https://lore.kernel.org/linux-doc/1575490683-13015-1-git-send-email-sj38.park@gmail.com/):
>>   - Rebased on Heidi Fahim's patch[2]
>>   - Fix failing kunit_tool_test test
>>   - Add 'build_dir' option test in 'kunit_tool_test.py'
>>

Please include Brendana Higgins on kunit patches.

thanks,
-- Shuah

  reply	other threads:[~2019-12-11 17:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05  9:34 [PATCH v5 0/6] Fix nits in the kunit SeongJae Park
2019-12-05  9:34 ` [PATCH v5 1/6] docs/kunit/start: Use in-tree 'kunit_defconfig' SeongJae Park
2019-12-05  9:34 ` [PATCH v5 2/6] kunit: Remove duplicated defconfig creation SeongJae Park
2019-12-05  9:34 ` [PATCH v5 3/6] kunit: Create default config in '--build_dir' SeongJae Park
2019-12-12  1:17   ` Brendan Higgins
2019-12-05  9:34 ` [PATCH v5 4/6] kunit: Place 'test.log' under the 'build_dir' SeongJae Park
2019-12-12  1:24   ` Brendan Higgins
2019-12-05  9:38 ` [PATCH v5 5/6] kunit: Rename 'kunitconfig' to '.kunitconfig' SeongJae Park
2019-12-05  9:38 ` [PATCH v5 6/6] kunit/kunit_tool_test: Test '--build_dir' option run SeongJae Park
2019-12-12  1:31   ` Brendan Higgins
2019-12-11 16:33 ` [PATCH v5 0/6] Fix nits in the kunit SeongJae Park
2019-12-11 17:22   ` shuah [this message]
2019-12-11 17:40     ` SeongJae Park
2019-12-11 17:45       ` Brendan Higgins
2019-12-12  2:06         ` Brendan Higgins
2019-12-12  2:12           ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3dab421e-6aa5-90e4-791e-53482f5c1fe8@kernel.org \
    --to=shuah@kernel.org \
    --cc=brendanhiggins@google.com \
    --cc=corbet@lwn.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=sj38.park@gmail.com \
    --cc=sjpark@amazon.com \
    --cc=sjpark@amazon.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).