From: SF Markus Elfring <elfring@users.sourceforge.net>
To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
Arun Easi <arun.easi@cavium.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
David Disseldorp <ddiss@suse.de>, Hannes Reinecke <hare@suse.com>,
Ingo Molnar <mingo@kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Jiang Yi <jiangyilism@gmail.com>,
Kees Cook <keescook@chromium.org>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Russell King <rmk+kernel@armlinux.org.uk>,
Tang Wenji <tang.wenji@zte.com.cn>,
"Theodore Ts'o" <tytso@mit.edu>,
Varun Prakash <varun@chelsio.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/8] target/iscsi: Delete an unnecessary variable initialisation in iscsit_allocate_ooo_cmdsn()
Date: Tue, 12 Dec 2017 22:46:42 +0100 [thread overview]
Message-ID: <3db75482-2817-46b1-95e5-ace7342e2a90@users.sourceforge.net> (raw)
In-Reply-To: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 12 Dec 2017 21:13:49 +0100
The local variable "ooo_cmdsn" will be reassigned by a following statement.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/target/iscsi/iscsi_target_erl1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/iscsi/iscsi_target_erl1.c b/drivers/target/iscsi/iscsi_target_erl1.c
index ff3e08b6d4e1..c4c550128161 100644
--- a/drivers/target/iscsi/iscsi_target_erl1.c
+++ b/drivers/target/iscsi/iscsi_target_erl1.c
@@ -782,7 +782,7 @@ int iscsit_recover_dataout_sequence(
static struct iscsi_ooo_cmdsn *iscsit_allocate_ooo_cmdsn(void)
{
- struct iscsi_ooo_cmdsn *ooo_cmdsn = NULL;
+ struct iscsi_ooo_cmdsn *ooo_cmdsn;
ooo_cmdsn = kmem_cache_zalloc(lio_ooo_cache, GFP_ATOMIC);
if (!ooo_cmdsn)
--
2.15.1
next prev parent reply other threads:[~2017-12-12 21:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 21:40 [PATCH 0/8] target-iSCSI: Adjustments for several function implementations SF Markus Elfring
2017-12-12 21:42 ` [PATCH 1/8] target/iscsi: Less function calls in chap_server_compute_md5() after error detection SF Markus Elfring
2017-12-12 21:43 ` [PATCH 2/8] target/iscsi: Move resetting of seven variables in chap_server_compute_md5() SF Markus Elfring
2017-12-12 21:45 ` [PATCH 3/8] target/iscsi: Delete 36 error messages for a failed memory allocation SF Markus Elfring
2017-12-12 21:46 ` SF Markus Elfring [this message]
2017-12-12 21:47 ` [PATCH 5/8] target/iscsi: Delete an unnecessary variable initialisation in iscsi_copy_param_list() SF Markus Elfring
2017-12-12 21:49 ` [PATCH 6/8] target/iscsi: Delete an unnecessary variable initialisation in iscsi_create_default_params() SF Markus Elfring
2017-12-12 21:50 ` [PATCH 7/8] target/iscsi: Delete an unnecessary variable initialisation in iscsi_set_default_param() SF Markus Elfring
2017-12-12 21:52 ` [PATCH 8/8] target/iscsi: Improve 16 size determinations SF Markus Elfring
2018-02-21 16:45 ` [PATCH 0/8] target-iSCSI: Adjustments for several function implementations SF Markus Elfring
[not found] ` <20180222143624.7c7241a1@suse.de>
2018-02-23 8:19 ` [0/8] " SF Markus Elfring
[not found] ` <20180222135600.5vv7vzw7sa5metcb@mwanda>
2018-02-23 9:06 ` SF Markus Elfring
2018-02-23 10:17 ` Dan Carpenter
2018-02-23 11:50 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3db75482-2817-46b1-95e5-ace7342e2a90@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Jason@zx2c4.com \
--cc=arun.easi@cavium.com \
--cc=bart.vanassche@sandisk.com \
--cc=dan.carpenter@oracle.com \
--cc=ddiss@suse.de \
--cc=hare@suse.com \
--cc=jiangyilism@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nab@linux-iscsi.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tang.wenji@zte.com.cn \
--cc=target-devel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=varun@chelsio.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).