From: David Laight <David.Laight@ACULAB.COM>
To: 'Adrian Ratiu' <adrian.ratiu@collabora.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Ard Biesheuvel <ardb@kernel.org>,
Arvind Sankar <nivedita@alum.mit.edu>,
clang-built-linux <clang-built-linux@googlegroups.com>,
"kernel@collabora.com" <kernel@collabora.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 1/2] arm: lib: xor-neon: remove unnecessary GCC < 4.6 warning
Date: Tue, 19 Jan 2021 22:04:20 +0000 [thread overview]
Message-ID: <3dbc2ce713e44e3a9a913db5446506a8@AcuMS.aculab.com> (raw)
In-Reply-To: <20210119131724.308884-2-adrian.ratiu@collabora.com>
From: Adrian Ratiu
> Sent: 19 January 2021 13:17
> To: linux-arm-kernel@lists.infradead.org
>
> Drop warning because kernel now requires GCC >= v4.9 after
> commit 6ec4476ac825 ("Raise gcc version requirement to 4.9")
> and clarify that -ftree-vectorize now always needs enabling
> for GCC by directly testing the presence of CONFIG_CC_IS_GCC.
...
> -#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)
> +#ifdef CONFIG_CC_IS_GCC
> #pragma GCC optimize "tree-vectorize"
> -#else
I thought that #pragma optimise was very likely to remove
a random subset of the command line parameters leading to
incorrect/unexpected code.
As such the extra option needs to passed in as a per source
file compiler option.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-01-19 22:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 13:17 [PATCH v4 0/2] xor-neon: Remove GCC warn & pragmas Adrian Ratiu
2021-01-19 13:17 ` [PATCH v4 1/2] arm: lib: xor-neon: remove unnecessary GCC < 4.6 warning Adrian Ratiu
2021-01-19 21:18 ` Nick Desaulniers
2021-01-19 21:34 ` Arnd Bergmann
2021-01-19 22:04 ` Nick Desaulniers
2021-01-19 23:10 ` Nick Desaulniers
2021-01-20 23:09 ` Nick Desaulniers
2021-01-20 23:15 ` Nick Desaulniers
2021-01-21 4:13 ` Arvind Sankar
2021-01-21 4:24 ` Nick Desaulniers
2021-01-21 8:46 ` Ard Biesheuvel
2021-01-20 13:11 ` Adrian Ratiu
2021-01-19 21:54 ` Nathan Chancellor
2021-01-20 13:18 ` Adrian Ratiu
2021-01-19 22:04 ` David Laight [this message]
2021-01-19 22:05 ` Nick Desaulniers
2021-01-19 13:17 ` [PATCH v4 2/2] arm: lib: xor-neon: move pragma options to makefile Adrian Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbc2ce713e44e3a9a913db5446506a8@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=adrian.ratiu@collabora.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).