From: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<helgaas@kernel.org>
Cc: <linux-pci@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mka@chromium.org>,
<quic_vbadigan@quicinc.com>, <quic_hemantk@quicinc.com>,
<quic_nitegupt@quicinc.com>, <quic_skananth@quicinc.com>,
<quic_ramkri@quicinc.com>, <manivannan.sadhasivam@linaro.org>,
<swboyd@chromium.org>, <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks
Date: Mon, 29 Aug 2022 23:15:43 +0530 [thread overview]
Message-ID: <3dd98ae4-8b19-e241-3b64-fe24509d2cb4@quicinc.com> (raw)
In-Reply-To: <75f8b257-7e0a-d871-ab30-37a72f7da56e@linaro.org>
On 7/6/2022 8:29 PM, Krzysztof Kozlowski wrote:
> On 06/07/2022 13:55, Krishna Chaitanya Chundru wrote:
>> On 7/4/2022 1:54 PM, Krzysztof Kozlowski wrote:
>>> On 01/07/2022 18:11, Krishna chaitanya chundru wrote:
>>>> Adding aggre0 and aggre1 clock entries to PCIe node.
>>>>
>>>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>>>> ---
>>>> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++--
>>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>> index 0b69b12..8f29bdd 100644
>>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>> @@ -423,8 +423,8 @@ allOf:
>>>> then:
>>>> properties:
>>>> clocks:
>>>> - minItems: 11
>>>> - maxItems: 11
>>>> + minItems: 13
>>>> + maxItems: 13
>>>> clock-names:
>>>> items:
>>>> - const: pipe # PIPE clock
>>>> @@ -437,6 +437,8 @@ allOf:
>>>> - const: bus_slave # Slave AXI clock
>>>> - const: slave_q2a # Slave Q2A clock
>>>> - const: tbu # PCIe TBU clock
>>>> + - const: aggre0 # Aggre NoC PCIe CENTER SF AXI clock
>>>> + - const: aggre1 # Aggre NoC PCIe1 AXI clock
>>> You ignored my comments from v1 - please don't. This is not accepted.
>>>
>>> Also, please do not send new versions of patchset as reply to some other
>>> threads. It's extremely confusing to find it under something else.
>>>
>>> Best regards,
>>> Krzysztof
>> Hi
>>
>> Krzysztof,
>>
>> Sorry for confusion created which replying this patch.
>>
>> The only comment I got from v1 from you is to run make dtbs_check.
>>
>> I ran that command I found the errors and fixed them and I ran the make dtbs_check again
>> before on v2 and made sure there are no errors.
>>
>> Can you please tell me is there any steps I missed.
> The comment was:
> "This won't work. You need to update other entry."
>
> and then a conditional: "If you test it with
> `make dtbs_check` you will see the errors."
>
> So let's run it together:
>
> /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sc7280-idp.dtb:
> pci@1c08000: clocks: [[42, 55], [42, 56], [41, 0], [39, 0], [42, 50],
> [42, 52], [42, 53], [42, 57], [42, 58], [42, 177], [42, 178], [42, 8],
> [42, 21]] is too long
>
> From schema:
> /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>
> /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sc7280-idp.dtb:
> pci@1c08000: clock-names: ['pipe', 'pipe_mux', 'phy_pipe', 'ref', 'aux',
> 'cfg', 'bus_master', 'bus_slave', 'slave_q2a', 'tbu', 'aggre0',
> 'aggre1', 'ddrss_sf_tbu'] is too long
>
>
> clocks and clock-names can be maximum 12 items, as defined by schema in
> "properties:" section. You cannot extend it in one place to 13 but leave
> 12 in other, because both constraints are applicable.
>
> If you test it, you will see the errors.
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Sorry for very late reply.
If we increase the common definitions of clocks properties to "13" it is
sufficient right.
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 92402f1..c9e268d 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -53,11 +53,11 @@ properties:
# Platform constraints are described later.
clocks:
minItems: 3
- maxItems: 12
+ maxItems: 13
clock-names:
minItems: 3
- maxItems: 12
+ maxItems: 13
resets:
Thanks & Regards,
Krishna Chaitanya.
next prev parent reply other threads:[~2022-08-29 17:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 9:19 [PATCH v1 0/3] PCI: qcom: sc7280: add missing clocks Krishna chaitanya chundru
2022-06-24 9:19 ` [PATCH v1 1/3] PCI: qcom: Add missing sc7280 clocks in PCIe driver Krishna chaitanya chundru
2022-06-24 17:05 ` Bjorn Helgaas
2022-06-24 21:06 ` Bjorn Helgaas
2022-06-28 6:39 ` Krishna Chaitanya Chundru
2022-06-24 9:19 ` [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks Krishna chaitanya chundru
2022-06-24 15:23 ` Krzysztof Kozlowski
2022-06-24 16:58 ` Bjorn Helgaas
2022-06-28 6:43 ` Krishna Chaitanya Chundru
2022-06-24 9:19 ` [PATCH v1 3/3] arm64: dts: qcom: sc7280: Add missing pcie clocks Krishna chaitanya chundru
2022-06-24 15:23 ` Krzysztof Kozlowski
2022-07-01 16:11 ` [PATCH v2 0/3] PCI: qcom: sc7280: add missing aggre0, aggre1 and ddrs sf tbu clocks Krishna chaitanya chundru
2022-07-01 16:11 ` [PATCH v2 1/3] PCI: qcom: Add sc7280 aggre0, aggre1 and ddr sf tbu clocks in PCIe driver Krishna chaitanya chundru
2022-07-01 16:11 ` [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks Krishna chaitanya chundru
2022-07-04 8:24 ` Krzysztof Kozlowski
2022-07-06 11:55 ` Krishna Chaitanya Chundru
2022-07-06 14:59 ` Krzysztof Kozlowski
2022-08-29 17:45 ` Krishna Chaitanya Chundru [this message]
2022-08-30 6:23 ` Krzysztof Kozlowski
2022-07-01 16:11 ` [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add missing " Krishna chaitanya chundru
2022-07-04 8:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dd98ae4-8b19-e241-3b64-fe24509d2cb4@quicinc.com \
--to=quic_krichai@quicinc.com \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=helgaas@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mka@chromium.org \
--cc=quic_hemantk@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).