From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933045AbdKGLVa (ORCPT ); Tue, 7 Nov 2017 06:21:30 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:37249 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932710AbdKGLV0 (ORCPT ); Tue, 7 Nov 2017 06:21:26 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20171107112124epoutp02c85adb4e9b3ca7ca57764710b72af2a4~0ydNl6fA51727317273epoutp02D X-AuditID: b6c32a35-84dff700000010bc-6d-5a019734834d Subject: Re: [PATCH 1/2] usbip: fix off-by-one frame number calculation To: Arnd Bergmann , Valentina Manea , Shuah Khan , Greg Kroah-Hartman Cc: Johan Hovold , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Opasiak Message-id: <3dde28df-64d5-4b2e-f044-04e73b3fb156@samsung.com> Date: Tue, 07 Nov 2017 12:21:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-version: 1.0 In-reply-to: <20171107104010.2884193-1-arnd@arndb.de> Content-type: text/plain; charset="utf-8"; format="flowed" Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsWy7bCmga7JdMYog0tb5C3+TjrGbtG8eD2b RdONHlaLy7vmsFksWtbKbDHl5Tp2i3eX5rI7sHv8/jWJ0WPnrLvsHptWdbJ57J+7ht3j8ya5 ANYoLpuU1JzMstQifbsEroyFm/ayFRxmrXi/WLeBcRtLFyMnh4SAicTWaXPYuxi5OIQEdjBK fP7fxArhfGeUOL2rC67q6qZ1jBCJDYwSrVenQlXdZ5RYefwxO0iVsIC7xLynP8ASIgJLGCX2 PnsO1s4sECdxd+4vpi5GDg42AX2JebtEQcK8AnYSH+ffYASxWQRUJRa0toDNERWIkLiw6ScT RI2gxI/J98DGcAqYShyYMocRYqSVxLN/rawQtrhEc+tNqFXyEpvXvGUGuUFC4ASbxOWuDYwQ L7hInGs6yA5hC0u8Or6FHeQeCQFpiUtHbSHq1zFKXNj6gA2iZjejRMvTaAjbWuLPqolsEAv4 JN597WGF6OWV6GgTgijxkPh0spkZwnaUeP1xBjSAOhglLk6+xzyBUW4Wkn9mIflhFpIfZiH5 YQEjyypGsdSC4tz01GLDAkO94sTc4tK8dL3k/NxNjOCkomW6g3HKOZ9DjAIcjEo8vDMOMkQJ sSaWFVfmHmKU4GBWEuHdrg4U4k1JrKxKLcqPLyrNSS0+xCjNwaIkziu6/lqEkEB6Yklqdmpq QWoRTJaJg1OqgdFt/tH5i6ZtfniHz+da21etEH+DDs27Z50Wr73Zy7Xc7dWpM3X/7vH/m9Ky 2O4JA2d8edyfRdHWD5i5o6yuzXe5J7A5OL1YMGVS3+u3ek/DtIR3/XBUjT6kaBV5PV3p7ctJ B1/HOpxLfy4W2bGIdcLqFYF281j8rOps7v2YGuxdKdSR1Brk/1aJpTgj0VCLuag4EQCjfxi7 JgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFLMWRmVeSWpSXmKPExsVy+t9jQV2T6YxRBsdm8Vj8nXSM3aJ58Xo2 i6YbPawWl3fNYbNYtKyV2WLKy3XsFu8uzWV3YPf4/WsSo8fOWXfZPTat6mTz2D93DbvH501y AaxRXDYpqTmZZalF+nYJXBkLN+1lKzjMWvF+sW4D4zaWLkZODgkBE4mrm9YxdjFycQgJrGOU 2LavnR3Cecgo0b7nJxNIlbCAu8S8pz9YQWwRgSWMEmff2oDYzAJxErtW7YZq6GKUmLrnKlAD BwebgL7EvF2iIDW8AnYSH+ffYASxWQRUJRa0trCDlIgKREhs2MgPUSIo8WPyPbCDOAVMJQ5M mcMIMd5M4svLw6wQtrhEc+tNFghbXmLzmrfMExgFZiFpn4WkZRaSlllIWhYwsqxilEwtKM5N zy02KjDMSy3XK07MLS7NS9dLzs/dxAiMgW2Htfp2MN5fEn+IUYCDUYmHd8ZBhigh1sSy4src Q4wSHMxKIrzb1YFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeW/nHYsUEkhPLEnNTk0tSC2CyTJx cEo1MCbGX4w0nMra/YXh4OFGvQXSqd+XV+eFcEWe9DogfXPen6KYX7f3GOzWmvgkiLOH52No ji3Dkze7j8/QVnuTua/l/pHl74Is+qfuywjm4z2YtIN/aaCRdF2RHnvfv2DBvM8hMisMTq1h msKw+nNareP/+aq/dDlv6k7J0o61eBV+VVB28o7fUUosxRmJhlrMRcWJAAkiSkt9AgAA X-CMS-MailID: 20171107112124epcas1p17a0bced83e147b5540626e7ea66d63a1 X-Msg-Generator: CA CMS-TYPE: 101P X-CMS-RootMailID: 20171107104018epcas5p1f9c72d541c679e1c5a44e03a901e8498 X-RootMTR: 20171107104018epcas5p1f9c72d541c679e1c5a44e03a901e8498 References: <20171107104010.2884193-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2017 11:39 AM, Arnd Bergmann wrote: > vgadget_get_frame returns a frame number from 0 to 2046, which > may require an expensive division operation to wrap at one lower > than the usual number. > > I can't see any reason for this, and all other drivers wrap at > a power-of-two number. My best explanation is that it was a simple > typo, so I'm changing the % modulo operator into a cheaper bitmask > that the other drivers use, to make it wrap after 0x7ff rather than > before it. > > Signed-off-by: Arnd Bergmann Looks good to me: Reviewed-by: Krzysztof Opasiak -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics