From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938493AbcKKV7H (ORCPT ); Fri, 11 Nov 2016 16:59:07 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59620 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935933AbcKKV7F (ORCPT ); Fri, 11 Nov 2016 16:59:05 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org EAFAB61506 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=spjoshi@codeaurora.org Subject: Re: [PATCH v2 2/3] firmware: qcom: scm: Remove core, iface and bus clocks dependency To: Stephen Boyd References: <1478218237-1737-1-git-send-email-spjoshi@codeaurora.org> <1478218237-1737-3-git-send-email-spjoshi@codeaurora.org> <20161110014718.GY16026@codeaurora.org> Cc: Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Jordan Crouse , Trilok Soni From: Sarangdhar Joshi Message-ID: <3e0c6e8e-9c5b-292a-24ae-4f3129dd44f4@codeaurora.org> Date: Fri, 11 Nov 2016 13:59:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161110014718.GY16026@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2016 05:47 PM, Stephen Boyd wrote: > On 11/03, Sarangdhar Joshi wrote: >> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c >> index d79fecd..844e90d 100644 >> --- a/drivers/firmware/qcom_scm.c >> +++ b/drivers/firmware/qcom_scm.c >> @@ -380,32 +384,40 @@ EXPORT_SYMBOL(qcom_scm_is_available); >> static int qcom_scm_probe(struct platform_device *pdev) >> { >> struct qcom_scm *scm; >> + uint32_t clks; > > If this was unsigned long flags; > >> int ret; >> >> scm = devm_kzalloc(&pdev->dev, sizeof(*scm), GFP_KERNEL); >> if (!scm) >> return -ENOMEM; >> >> - scm->core_clk = devm_clk_get(&pdev->dev, "core"); >> - if (IS_ERR(scm->core_clk)) { >> - if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER) >> - return PTR_ERR(scm->core_clk); >> + clks = (uint32_t)((uintptr_t)of_device_get_match_data(&pdev->dev)); > > then this could just be a cast to unsigned long? I saw quite a few places in kernel where similar type casts are used (e.g gpio drivers) and ended up using uint32_t. uintptr_t is nothing but typedef of an unsigned long. Probably it's a good idea to just use unsigned long instead. > >> + if (clks & SCM_HAS_CORE_CLK) { >> + scm->core_clk = devm_clk_get(&pdev->dev, "core"); >> + if (IS_ERR(scm->core_clk)) { >> + if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER) >> + return PTR_ERR(scm->core_clk); >> >> - scm->core_clk = NULL; >> + scm->core_clk = NULL; >> + } >> } > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project