From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86FECC4361B for ; Fri, 18 Dec 2020 00:51:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55EBC23A53 for ; Fri, 18 Dec 2020 00:51:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731598AbgLRAvZ (ORCPT ); Thu, 17 Dec 2020 19:51:25 -0500 Received: from smtprelay0005.hostedemail.com ([216.40.44.5]:45206 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727177AbgLRAvZ (ORCPT ); Thu, 17 Dec 2020 19:51:25 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 8CA2E180A7FEA; Fri, 18 Dec 2020 00:50:43 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: horn93_441077427439 X-Filterd-Recvd-Size: 3580 Received: from XPS-9350.home (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Fri, 18 Dec 2020 00:50:42 +0000 (UTC) Message-ID: <3e21b6e87e219d6538a193a9021b965fd8180025.camel@perches.com> Subject: Re: [PATCH] checkpatch: add warning for non-lore mailing list URLs From: Joe Perches To: Bjorn Helgaas , Andy Whitcroft Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas Date: Thu, 17 Dec 2020 16:50:41 -0800 In-Reply-To: <20201217235615.43328-1-helgaas@kernel.org> References: <20201217235615.43328-1-helgaas@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-12-17 at 17:56 -0600, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > The lkml.org, marc.info, spinics.net, etc archives are not quite as useful > as lore.kernel.org because they use different styles, add advertising, and > may disappear in the future. The lore archives are more consistent and > more likely to stick around, so prefer https://lore.kernel.org URLs when > they exist. Hi Bjorn. I like the idea, thanks, but a couple notes. > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -564,6 +564,17 @@ sub find_standard_signature { >   return ""; >  } > +our $obsolete_archives = qr{(?xi: > + freedesktop.org/archives/dri-devel| > + lists.infradead.org| > + lkml.org| > + mail-archive.com| > + mailman.alsa-project.org/pipermail| > + marc.info| > + ozlabs.org/pipermail| > + spinics.net > +)}; Strictly, these all need \Q \E escaping so uses like lkmlAorg do not match. > @@ -3101,6 +3112,12 @@ sub process { >   } >   } >   > +# Check for mailing list archives other than lore.kernel.org > + if ($line =~ /(http|https):\/\/\S*$obsolete_archives/) { The https?:// doesn't seem necessary. Perhaps: if ($line =~ m{\b$obsolete_archives}) { > + WARN("PREFER_LORE_ARCHIVE", > + "Use lore.kernel.org archive links when possible; see https://lore.kernel.org/lists.html\n" . $herecurr); Perhaps: "Prefer lore.kernel.org links. see: https://www.kernel.org/lore.html#linking-to-list-discussions-from-commits\n" . $herecurr); So maybe instead: --- scripts/checkpatch.pl | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 00085308ed9d..c2a324d628a6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -564,6 +564,17 @@ sub find_standard_signature { return ""; } +our $obsolete_archives = qr{(?xi: + \Qfreedesktop.org/archives/dri-devel\E | + \Qlists.infradead.org\E | + \Qlkml.org\E | + \Qmail-archive.com\E | + \Qmailman.alsa-project.org/pipermail\E | + \Qmarc.info\E | + \Qozlabs.org/pipermail\E | + \Qspinics.net\E +)}; + our @typeListMisordered = ( qr{char\s+(?:un)?signed}, qr{int\s+(?:(?:un)?signed\s+)?short\s}, @@ -3101,6 +3112,12 @@ sub process { } } + # Check for mailing list archives other than lore.kernel.org + if ($rawline =~ m{\b$obsolete_archives}) { + WARN("PREFER_LORE_ARCHIVE", + "Use lore.kernel.org archive links when possible - see https://lore.kernel.org/lists.html\n" . $herecurr); + } + # Check for added, moved or deleted files if (!$reported_maintainer_file && !$in_commit_log && ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||