From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Samuel Holland <samuel@sholland.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v3 3/4] dt-bindings: sram: sunxi-sram: Add optional regulators child
Date: Tue, 16 Aug 2022 12:59:39 +0300 [thread overview]
Message-ID: <3e23c288-7065-a3fd-c326-8d66e168ba41@linaro.org> (raw)
In-Reply-To: <20220815043436.20170-4-samuel@sholland.org>
On 15/08/2022 07:34, Samuel Holland wrote:
> Some sunxi SoCs have in-package regulators controlled by a register in
> the system control MMIO block. Allow a child node for these regulators
> in addition to SRAM child nodes.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> Changes in v3:
> - Require the regulators node to have a unit address
> - Reference the regulator schema from the SRAM controller schema
> - Move the system LDOs example to the SRAM controller schema
> - Reorder the patches so the example passes validation
>
> Changes in v2:
> - New patch for v2
>
> .../allwinner,sun4i-a10-system-control.yaml | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> index d64c1b28fb61..915ca85c3f10 100644
> --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> @@ -56,6 +56,10 @@ properties:
> ranges: true
>
> patternProperties:
> + "^regulators@[0-9a-f]+$":
> + $ref: /schemas/regulator/allwinner,sun20i-d1-system-ldos.yaml#
> + unevaluatedProperties: false
unevaluatedProperties is not needed. Your other schema does not allow
anything else here.
> +
> "^sram@[a-z0-9]+":
> type: object
>
> @@ -130,3 +134,28 @@ examples:
> };
> };
> };
> +
> + - |
> + syscon@3000000 {
> + compatible = "allwinner,sun20i-d1-system-control";
Your other example uses simple-mfd, syscon... A bit confusing.
> + reg = <0x3000000 0x1000>;
> + ranges;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + regulators@3000150 {
> + compatible = "allwinner,sun20i-d1-system-ldos";
> + reg = <0x3000150 0x4>;
> +
> + reg_ldoa: ldoa {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + reg_ldob: ldob {
> + regulator-name = "vcc-dram";
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> + };
> + };
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-16 10:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 4:34 [PATCH v3 0/4] regulator: Add support for Allwinner D1 LDOs Samuel Holland
2022-08-15 4:34 ` [PATCH v3 1/4] regulator: dt-bindings: Add " Samuel Holland
2022-08-15 15:32 ` Heiko Stübner
2022-08-16 10:00 ` Krzysztof Kozlowski
2022-08-16 9:55 ` Krzysztof Kozlowski
2022-08-17 8:15 ` Samuel Holland
2022-08-17 8:27 ` Krzysztof Kozlowski
2022-08-17 8:39 ` Samuel Holland
2022-08-17 8:46 ` Krzysztof Kozlowski
2022-08-17 13:46 ` Krzysztof Kozlowski
2022-08-16 9:57 ` Krzysztof Kozlowski
2022-08-15 4:34 ` [PATCH v3 2/4] regulator: sun20i: Add support for " Samuel Holland
2022-08-15 17:00 ` Heiko Stübner
2022-08-17 8:28 ` Samuel Holland
2022-08-17 10:01 ` Heiko Stübner
2022-08-15 4:34 ` [PATCH v3 3/4] dt-bindings: sram: sunxi-sram: Add optional regulators child Samuel Holland
2022-08-15 14:01 ` Rob Herring
2022-08-15 17:02 ` Heiko Stübner
2022-08-16 9:59 ` Krzysztof Kozlowski [this message]
2022-08-17 8:47 ` Samuel Holland
2022-08-17 13:22 ` Krzysztof Kozlowski
2022-08-15 4:34 ` [PATCH v3 4/4] soc: sunxi: sram: Only iterate over SRAM children Samuel Holland
2022-08-15 17:04 ` Heiko Stübner
2022-08-16 10:01 ` Krzysztof Kozlowski
2022-08-16 10:03 ` Krzysztof Kozlowski
2022-08-17 8:50 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e23c288-7065-a3fd-c326-8d66e168ba41@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).