From: Shreeya Patel <shreeya.patel@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: sanju.mehta@amd.com, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com,
krisman@collabora.com, alvaro.soliverez@collabora.com,
Lucas Tanure <tanureal@opensource.cirrus.com>
Subject: Re: [PATCH] spi: amd: Configure device speed
Date: Wed, 17 Aug 2022 19:40:31 +0530 [thread overview]
Message-ID: <3e2a0f50-c396-5af6-5cbe-303978378587@collabora.com> (raw)
In-Reply-To: <Yvzw0GqUd9ZgxUTo@sirena.org.uk>
On 17/08/22 19:14, Mark Brown wrote:
> On Wed, Aug 17, 2022 at 06:48:09PM +0530, Shreeya Patel wrote:
>
>> Create mechanism to configure device clock frequency such
>> that it is the closest frequency supported by the
>> AMD controller.
> You shouldn't use the closest, you should use a frequency which is
> strictly less than the requested one - driving things too fast will
> generally break but too slow is pretty much always fine.
Hi Mark,
yes, the code is actually configuring it to use the frequency which is
strictly less than the requested one.
I just didn't use the correct words. I will make the change in commit
message for v2 once you review the patch.
Thanks
Shreeya Patel
next prev parent reply other threads:[~2022-08-17 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 13:18 [PATCH] spi: amd: Configure device speed Shreeya Patel
2022-08-17 13:44 ` Mark Brown
2022-08-17 14:10 ` Shreeya Patel [this message]
2022-08-18 13:23 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2022-03-17 14:14 André Almeida
2022-03-17 18:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e2a0f50-c396-5af6-5cbe-303978378587@collabora.com \
--to=shreeya.patel@collabora.com \
--cc=alvaro.soliverez@collabora.com \
--cc=broonie@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sanju.mehta@amd.com \
--cc=tanureal@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).