From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43997C07E9C for ; Sat, 10 Jul 2021 09:20:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29CA56139A for ; Sat, 10 Jul 2021 09:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232363AbhGJJXc (ORCPT ); Sat, 10 Jul 2021 05:23:32 -0400 Received: from mxout04.lancloud.ru ([45.84.86.114]:54206 "EHLO mxout04.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231877AbhGJJXb (ORCPT ); Sat, 10 Jul 2021 05:23:31 -0400 X-Greylist: delayed 353 seconds by postgrey-1.27 at vger.kernel.org; Sat, 10 Jul 2021 05:23:30 EDT Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 2035420ABA32 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH AUTOSEL 4.19 05/39] scsi: hisi_sas: Propagate errors in interrupt_init_v1_hw() To: Sasha Levin , , CC: John Garry , "Martin K . Petersen" , References: <20210710023204.3171428-1-sashal@kernel.org> <20210710023204.3171428-5-sashal@kernel.org> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <3e2af821-00e3-6db9-5820-696fdbe003d6@omp.ru> Date: Sat, 10 Jul 2021 12:20:43 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210710023204.3171428-5-sashal@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.07.2021 5:31, Sasha Levin wrote: > From: Sergey Shtylyov > > [ Upstream commit ab17122e758ef68fb21033e25c041144067975f5 ] > > After commit 6c11dc060427 ("scsi: hisi_sas: Fix IRQ checks") we have the > error codes returned by platform_get_irq() ready for the propagation > upsream in interrupt_init_v1_hw() -- that will fix still broken deferred > probing. Let's propagate the error codes from devm_request_irq() as well > since I don't see the reason to override them with -ENOENT... > > Link: https://lore.kernel.org/r/49ba93a3-d427-7542-d85a-b74fe1a33a73@omp.ru > Acked-by: John Garry > Signed-off-by: Sergey Shtylyov > Signed-off-by: Martin K. Petersen > Signed-off-by: Sasha Levin > --- > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c > index 8aa3222fe486..5a777e48963b 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c [...] > @@ -1717,7 +1717,7 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba) > if (!irq) { > dev_err(dev, "irq init: could not map cq interrupt %d\n", > idx); > - return -ENOENT; > + return irq; This patch is borked too, we don't want to return 0 here... [...] MBR, Sergei