Re: [PATCH] ASoC: amd: AMD RV RT5682 should depends on CROS_EC

From: Randy Dunlap <rdunlap@infradead.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	linux-kernel@vger.kernel.org
Cc: Collabora Kernel ML <kernel@collabora.com>,
	Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org,
	Akshu Agrawal <akshu.agrawal@amd.com>,
	Mark Brown <broonie@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH] ASoC: amd: AMD RV RT5682 should depends on CROS_EC
Date: Tue, 3 Mar 2020 08:54:34 -0800	[thread overview]
Message-ID: <3e34a902-2a7c-c13c-d569-9d6479a65627@infradead.org> (raw)
In-Reply-To: <20200303110514.3267126-1-enric.balletbo@collabora.com>

On 3/3/20 3:05 AM, Enric Balletbo i Serra wrote:
> If SND_SOC_AMD_RV_RT5682_MACH=y, below kconfig and build errors can be seen:
> 
>  WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC
>  WARNING: unmet direct dependencies detected for I2C_CROS_EC_TUNNEL
> 
>  ld: drivers/i2c/busses/i2c-cros-ec-tunnel.o: in function `ec_i2c_xfer':
>  i2c-cros-ec-tunnel.c:(.text+0x2fc): undefined reference to `cros_ec_cmd_xfer_status'
>  ld: sound/soc/codecs/cros_ec_codec.o: in function `wov_host_event':
>  cros_ec_codec.c:(.text+0x4fb): undefined reference to `cros_ec_get_host_event'
>  ld: sound/soc/codecs/cros_ec_codec.o: in function `send_ec_host_command':
>  cros_ec_codec.c:(.text+0x831): undefined reference to `cros_ec_cmd_xfer_status'
> 
> This is because it will select SND_SOC_CROS_EC_CODEC and I2c_CROS_EC_TUNNEL but
> both depends on CROS_EC.
> 
> Fixes: 6b8e4e7db3cd ("ASoC: amd: Add machine driver for Raven based platform")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
> 
>  sound/soc/amd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index b29ef1373946..bce4cee5cb54 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -33,6 +33,6 @@ config SND_SOC_AMD_RV_RT5682_MACH
>  	select SND_SOC_MAX98357A
>  	select SND_SOC_CROS_EC_CODEC
>  	select I2C_CROS_EC_TUNNEL
> -	depends on SND_SOC_AMD_ACP3x && I2C
> +	depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC
>  	help
>  	 This option enables machine driver for RT5682 and MAX9835.
> 

-- 
~Randy