From: "Yanchao Yang (杨彦超)" <Yanchao.Yang@mediatek.com>
To: "pabeni@redhat.com" <pabeni@redhat.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"loic.poulain@linaro.org" <loic.poulain@linaro.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"edumazet@google.com" <edumazet@google.com>
Cc: "Chris Feng (冯保林)" <Chris.Feng@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Mingliang Xu (徐明亮)" <mingliang.xu@mediatek.com>,
"Min Dong (董敏)" <min.dong@mediatek.com>,
"linuxwwan@intel.com" <linuxwwan@intel.com>,
"m.chetan.kumar@intel.com" <m.chetan.kumar@intel.com>,
"Liang Lu (吕亮)" <liang.lu@mediatek.com>,
"Haijun Liu (刘海军)" <haijun.liu@mediatek.com>,
"Haozhe Chang (常浩哲)" <Haozhe.Chang@mediatek.com>,
"Hua Yang (杨华)" <Hua.Yang@mediatek.com>,
"Xiayu.Zhang@medi" <Xiayu.Zhang@medi>,
"ryazanov.s.a@gmail.com" <ryazanov.s.a@gmail.com>
Subject: Re: [PATCH net-next v3 01/10] net: wwan: tmi: Add PCIe core
Date: Wed, 1 Mar 2023 03:35:05 +0000 [thread overview]
Message-ID: <3e38940908752018bda7912f294d7a7c390657b7.camel@mediatek.com> (raw)
In-Reply-To: <20230228103132.325def4c@kernel.org>
On Tue, 2023-02-28 at 10:31 -0800, Jakub Kicinski wrote:
> On Tue, 28 Feb 2023 07:47:09 +0000 Yanchao Yang (杨彦超) wrote:
> > 1. We receive many comments at the beginning of several patches.
> > There
> > are little comments about other patches. How about other patches
> > (patch
> > 2~patch 10)?
>
> It's because patches are too long, so reviewers are unlikely to
> allocate sufficiently long block of time to look thru all of
> the code in one sitting.
>
Get it. It’s hard to review the whole patches in one sitting. So V3 has
been reduced 4k+ lines compared with V2 according to your suggestion.
Do you have any suggestions on that should we wait for feedback on
other patches or what we can do to help reviewers to review patches
more smoothly?
BTW, the patches are reviewed one by one (patch1, patch2, ….), or are
controlled by reviewers (there is no obvious order for reviewing the
patch)?
> > 2. Need we add your name in the tag “Reviewed-by: “ next version?
>
> No, no, don't put review tags on patches unless explicitly asked to.
Get it.
Many thanks.
next prev parent reply other threads:[~2023-03-01 3:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 8:37 [PATCH net-next v3 00/10] net: wwan: tmi: PCIe driver for MediaTek M.2 modem Yanchao Yang
2023-02-11 8:37 ` [PATCH net-next v3 01/10] net: wwan: tmi: Add PCIe core Yanchao Yang
2023-02-15 4:22 ` Jakub Kicinski
2023-02-16 12:50 ` Yanchao Yang (杨彦超)
2023-02-16 18:10 ` Jakub Kicinski
2023-02-24 7:39 ` Yanchao Yang (杨彦超)
2023-02-24 19:50 ` Jakub Kicinski
2023-02-27 12:11 ` Yanchao Yang (杨彦超)
2023-02-27 19:00 ` Jakub Kicinski
2023-02-28 7:47 ` Yanchao Yang (杨彦超)
[not found] ` <20230228103132.325def4c@kernel.org>
2023-03-01 3:35 ` Yanchao Yang (杨彦超) [this message]
2023-03-01 4:05 ` Jakub Kicinski
2023-03-02 9:08 ` Yanchao Yang (杨彦超)
2023-03-17 8:50 ` Yanchao Yang (杨彦超)
2023-02-11 8:37 ` [PATCH net-next v3 02/10] net: wwan: tmi: Add control plane transaction layer Yanchao Yang
2023-02-11 8:37 ` [PATCH net-next v3 03/10] net: wwan: tmi: Add control DMA interface Yanchao Yang
2023-02-11 8:37 ` [PATCH net-next v3 04/10] net: wwan: tmi: Add control port Yanchao Yang
2023-02-11 8:37 ` [PATCH net-next v3 05/10] net: wwan: tmi: Add FSM thread Yanchao Yang
2023-02-11 8:37 ` [PATCH net-next v3 06/10] net: wwan: tmi: Add AT & MBIM WWAN ports Yanchao Yang
2023-02-11 8:37 ` [PATCH net-next v3 07/10] net: wwan: tmi: Introduce data plane hardware interface Yanchao Yang
2023-02-11 8:37 ` [PATCH net-next v3 08/10] net: wwan: tmi: Add data plane transaction layer Yanchao Yang
2023-02-11 8:37 ` [PATCH net-next v3 09/10] net: wwan: tmi: Introduce WWAN interface Yanchao Yang
2023-02-11 8:37 ` [PATCH net-next v3 10/10] net: wwan: tmi: Add maintainers and documentation Yanchao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e38940908752018bda7912f294d7a7c390657b7.camel@mediatek.com \
--to=yanchao.yang@mediatek.com \
--cc=Chris.Feng@mediatek.com \
--cc=Haozhe.Chang@mediatek.com \
--cc=Hua.Yang@mediatek.com \
--cc=Xiayu.Zhang@medi \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haijun.liu@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=liang.lu@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@intel.com \
--cc=min.dong@mediatek.com \
--cc=mingliang.xu@mediatek.com \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).