linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Víctor Manuel Jáquez Leal" <vjaquez@igalia.com>
To: Omar Ramirez Luna <omar.ramirez@ti.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Armando Uribe <x0095078@ti.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-omap@vger.kernel.org,
	Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH v2 7/8] staging: tidspbridge: clean up bridge_mmap()
Date: Tue, 31 Jan 2012 00:12:23 +0100	[thread overview]
Message-ID: <3e41ab813d19445abed5478cbb271038bbdc70bf.1327964066.git.vjaquez@igalia.com> (raw)
In-Reply-To: <cover.1327964066.git.vjaquez@igalia.com>
In-Reply-To: <cover.1327964066.git.vjaquez@igalia.com>

The variable offset is not used but in the debug log, so I don't see reason to
calculate it here.

Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
---
 drivers/staging/tidspbridge/rmgr/drv_interface.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c b/drivers/staging/tidspbridge/rmgr/drv_interface.c
index 97c40ff..5f810b6 100644
--- a/drivers/staging/tidspbridge/rmgr/drv_interface.c
+++ b/drivers/staging/tidspbridge/rmgr/drv_interface.c
@@ -257,7 +257,6 @@ err:
 /* This function maps kernel space memory to user space memory. */
 static int bridge_mmap(struct file *filp, struct vm_area_struct *vma)
 {
-	u32 offset = vma->vm_pgoff << PAGE_SHIFT;
 	u32 status;
 
 	DBC_ASSERT(vma->vm_start < vma->vm_end);
@@ -265,8 +264,8 @@ static int bridge_mmap(struct file *filp, struct vm_area_struct *vma)
 	vma->vm_flags |= VM_RESERVED | VM_IO;
 	vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
 
-	dev_dbg(bridge, "%s: vm filp %p offset %x start %lx end %lx page_prot "
-		"%ulx flags %lx\n", __func__, filp, offset,
+	dev_dbg(bridge, "%s: vm filp %p start %lx end %lx page_prot %ulx "
+		"flags %lx\n", __func__, filp,
 		vma->vm_start, vma->vm_end, vma->vm_page_prot,
 		vma->vm_flags);
 
-- 
1.7.8.3


  parent reply	other threads:[~2012-01-30 23:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 23:12 [PATCH v2 0/8] staging: tidspbridge: clean up drv_interface.c Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 1/8] staging: tidspbridge: more readable code Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 2/8] staging: tidspbridge: remove unused header Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 3/8] staging: tidspbridge: Lindent to drv_interface.c Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 4/8] staging: tidspbridge: silence the compiler Víctor Manuel Jáquez Leal
2012-01-31  8:05   ` Dan Carpenter
2012-01-31 11:19     ` Víctor M. Jáquez L.
2012-01-31 11:29       ` Dan Carpenter
2012-02-02 22:51   ` Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 5/8] staging: tidspbridge: remove header inclusions Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 6/8] staging: tidspbridge: remove trivial assert Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` Víctor Manuel Jáquez Leal [this message]
2012-01-30 23:12 ` [PATCH v2 8/8] staging: tidspbridge: use the driver name string Víctor Manuel Jáquez Leal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e41ab813d19445abed5478cbb271038bbdc70bf.1327964066.git.vjaquez@igalia.com \
    --to=vjaquez@igalia.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=felipe.contreras@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=omar.ramirez@ti.com \
    --cc=x0095078@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).