From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763366AbdAKKcK (ORCPT ); Wed, 11 Jan 2017 05:32:10 -0500 Received: from smtp.nue.novell.com ([195.135.221.5]:38867 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758285AbdAKKcI (ORCPT ); Wed, 11 Jan 2017 05:32:08 -0500 Subject: Re: [PATCH v6 04/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_prepare() To: Hanjun Guo , Marc Zyngier , "Rafael J. Wysocki" , Lorenzo Pieralisi References: <1483363905-2806-1-git-send-email-hanjun.guo@linaro.org> <1483363905-2806-5-git-send-email-hanjun.guo@linaro.org> Cc: huxinwei@huawei.com, Kefeng Wang , charles.garcia-tobin@arm.com, Jon Masters , yimin@huawei.com, Greg KH , linux-kernel@vger.kernel.org, linuxarm@huawei.com, Sinan Kaya , linux-acpi@vger.kernel.org, Tomasz Nowicki , Thomas Gleixner , Agustin Vega-Frias , linux-arm-kernel@lists.infradead.org, Ma Jun From: Matthias Brugger Message-ID: <3e4a817f-c67f-fd1c-08a6-dafd688badc7@suse.com> Date: Wed, 11 Jan 2017 11:31:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1483363905-2806-5-git-send-email-hanjun.guo@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/17 14:31, Hanjun Guo wrote: > Adding ACPI support for platform MSI, we need to retrieve the > dev id in ACPI way instead of device tree, we already have > a well formed function its_pmsi_prepare() to get the dev id > but it's OF dependent, so collect OF related code and put them > into a single function to make its_pmsi_prepare() more friendly > to ACPI later. > > Signed-off-by: Hanjun Guo > Tested-by: Sinan Kaya > Tested-by: Majun > Tested-by: Xinwei Kong > Cc: Marc Zyngier > Cc: Lorenzo Pieralisi > Cc: Tomasz Nowicki > Cc: Thomas Gleixner > --- > drivers/irqchip/irq-gic-v3-its-platform-msi.c | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) > Reviewed-by: Matthias Brugger > diff --git a/drivers/irqchip/irq-gic-v3-its-platform-msi.c b/drivers/irqchip/irq-gic-v3-its-platform-msi.c > index 470b4aa..3c94278 100644 > --- a/drivers/irqchip/irq-gic-v3-its-platform-msi.c > +++ b/drivers/irqchip/irq-gic-v3-its-platform-msi.c > @@ -24,15 +24,11 @@ > .name = "ITS-pMSI", > }; > > -static int its_pmsi_prepare(struct irq_domain *domain, struct device *dev, > - int nvec, msi_alloc_info_t *info) > +static int of_pmsi_get_dev_id(struct irq_domain *domain, struct device *dev, > + u32 *dev_id) > { > - struct msi_domain_info *msi_info; > - u32 dev_id; > int ret, index = 0; > > - msi_info = msi_get_domain_info(domain->parent); > - > /* Suck the DeviceID out of the msi-parent property */ > do { > struct of_phandle_args args; > @@ -43,11 +39,24 @@ static int its_pmsi_prepare(struct irq_domain *domain, struct device *dev, > if (args.np == irq_domain_get_of_node(domain)) { > if (WARN_ON(args.args_count != 1)) > return -EINVAL; > - dev_id = args.args[0]; > + *dev_id = args.args[0]; > break; > } > } while (!ret); > > + return ret; > +} > + > +static int its_pmsi_prepare(struct irq_domain *domain, struct device *dev, > + int nvec, msi_alloc_info_t *info) > +{ > + struct msi_domain_info *msi_info; > + u32 dev_id; > + int ret; > + > + msi_info = msi_get_domain_info(domain->parent); > + > + ret = of_pmsi_get_dev_id(domain, dev, &dev_id); > if (ret) > return ret; > >