From: YueHaibing <yuehaibing@huawei.com>
To: Borislav Petkov <bp@alien8.de>
Cc: <linux-edac@vger.kernel.org>, <ravi@jetztechnologies.com>,
<arvino55@gmail.com>, <mchehab@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] edac: i82975x: remove set but not used variable 'dtype'
Date: Wed, 7 Nov 2018 09:28:34 +0800 [thread overview]
Message-ID: <3e4fefcf-588b-9999-e8d2-4d0eb9a11585@huawei.com> (raw)
In-Reply-To: <20181106180526.GL13712@zn.tnic>
On 2018/11/7 2:05, Borislav Petkov wrote:
> On Thu, Nov 01, 2018 at 10:26:04AM +0800, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/edac/i82975x_edac.c:378:16: warning:
>> variable ‘dtype’ set but not used [-Wunused-but-set-variable]
>>
>> It never used since introduction in commit
>> 084a4fccef39 ("edac: move dimm properties to struct dimm_info")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/edac/i82975x_edac.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
>> index 892815e..ae0d8fa 100644
>> --- a/drivers/edac/i82975x_edac.c
>> +++ b/drivers/edac/i82975x_edac.c
>> @@ -375,7 +375,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
>> u32 cumul_size, nr_pages;
>> int index, chan;
>> struct dimm_info *dimm;
>> - enum dev_type dtype;
>>
>> last_cumul_size = 0;
>>
>> @@ -413,7 +412,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
>> * [0-7] for single-channel; i.e. csrow->nr_channels = 1
>> * [0-3] for dual-channel; i.e. csrow->nr_channels = 2
>> */
>> - dtype = i82975x_dram_type(mch_window, index);
>
> Please get rid of that silly function too and move the comment and the
> assignment to the single place where it is done:
>
> /*
> * ECC is possible on i92975x ONLY with DEV_X8
> */
> dimm->dtype = DEV_X8;
>
OK, will send v2.
>
> Thx.
>
prev parent reply other threads:[~2018-11-07 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 2:26 [PATCH -next] edac: i82975x: remove set but not used variable 'dtype' YueHaibing
2018-11-06 18:05 ` Borislav Petkov
2018-11-07 1:28 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e4fefcf-588b-9999-e8d2-4d0eb9a11585@huawei.com \
--to=yuehaibing@huawei.com \
--cc=arvino55@gmail.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ravi@jetztechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).