From: Eddie James <eajames@linux.vnet.ibm.com>
To: Joel Stanley <joel@jms.id.au>, eajames@linux.ibm.com
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
hverkuil@xs4all.nl, Rob Herring <robh+dt@kernel.org>,
mchehab@kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: media: Add Aspeed Video Engine binding documentation
Date: Mon, 1 Oct 2018 10:20:57 -0500 [thread overview]
Message-ID: <3e53dda4-81c4-1009-add2-45a3a7998e4e@linux.vnet.ibm.com> (raw)
In-Reply-To: <CACPK8Xd0MhrFQqiM=u-Rv5u7RJRo5R-pAejH4dmeTrYSWE0AZA@mail.gmail.com>
On 10/01/2018 08:08 AM, Joel Stanley wrote:
> On Tue, 25 Sep 2018 at 21:27, Eddie James <eajames@linux.ibm.com> wrote:
>> Document the bindings.
>>
>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>> ---
>> .../devicetree/bindings/media/aspeed-video.txt | 26 ++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/media/aspeed-video.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/aspeed-video.txt b/Documentation/devicetree/bindings/media/aspeed-video.txt
>> new file mode 100644
>> index 0000000..f1af528
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/aspeed-video.txt
>> @@ -0,0 +1,26 @@
>> +* Device tree bindings for Aspeed Video Engine
>> +
>> +The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs can
>> +capture and compress video data from digital or analog sources.
>> +
>> +Required properties:
>> + - compatible: "aspeed,ast2400-video-engine" or
>> + "aspeed,ast2500-video-engine"
>> + - reg: contains the offset and length of the VE memory region
>> + - clocks: clock specifiers for the syscon clocks associated with
>> + the VE (ordering must match the clock-names property)
>> + - clock-names: "vclk" and "eclk"
>> + - resets: reset specifier for the syscon reset associaated with
> associated
Good catch, thanks.
>
>> + the VE
>> + - interrupts: the interrupt associated with the VE on this platform
>> +
>> +Example:
>> +
>> +video-engine@1e700000 {
>> + compatible = "aspeed,ast2500-video-engine";
>> + reg = <0x1e700000 0x20000>;
>> + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
>> + clock-names = "vclk", "eclk";
> Did you end up sending the clock patches out?
Yes,
https://lore.kernel.org/patchwork/patch/978979/
https://lore.kernel.org/patchwork/patch/978976/
Do I need to send them as a separate series?
Thanks,
Eddie
>
> Cheers,
>
> Joel
>
>> + resets = <&syscon ASPEED_RESET_VIDEO>;
>> + interrupts = <7>;
>> +};
>> --
>> 1.8.3.1
>>
next prev parent reply other threads:[~2018-10-01 15:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 19:27 [PATCH v3 0/2] media: platform: Add Aspeed Video Engine Driver Eddie James
2018-09-25 19:27 ` [PATCH v3 1/2] dt-bindings: media: Add Aspeed Video Engine binding documentation Eddie James
2018-09-27 19:54 ` Rob Herring
2018-10-01 13:08 ` Joel Stanley
2018-10-01 15:20 ` Eddie James [this message]
2018-09-25 19:27 ` [PATCH v3 2/2] media: platform: Add Aspeed Video Engine driver Eddie James
2018-09-28 11:30 ` Hans Verkuil
2018-09-28 16:06 ` Eddie James
2018-10-03 20:26 ` Eddie James
2018-10-04 13:02 ` Hans Verkuil
2018-10-03 20:43 ` Eddie James
2018-10-04 13:12 ` Hans Verkuil
2018-10-05 20:03 ` Eddie James
2018-09-26 12:03 ` [PATCH v3 0/2] media: platform: Add Aspeed Video Engine Driver Hans Verkuil
2018-09-26 18:05 ` Eddie James
2018-09-28 11:29 ` Hans Verkuil
2018-09-28 11:45 ` Hans Verkuil
2018-09-28 16:09 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e53dda4-81c4-1009-add2-45a3a7998e4e@linux.vnet.ibm.com \
--to=eajames@linux.vnet.ibm.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=hverkuil@xs4all.nl \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).