From: David Laight <David.Laight@ACULAB.COM>
To: 'Thomas Gleixner' <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>
Cc: Yi Wang <wang.yi59@zte.com.cn>, Michael Matz <matz@suse.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"puwen@hygon.cn" <puwen@hygon.cn>,
"davidwang@zhaoxin.com" <davidwang@zhaoxin.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"zhong.weidong@zte.com.cn" <zhong.weidong@zte.com.cn>
Subject: RE: [PATCH v2] x86/cpu: fix prototype warning
Date: Fri, 9 Nov 2018 16:07:01 +0000 [thread overview]
Message-ID: <3e5713c2f323453d80bdd2259e3392e5@AcuMS.aculab.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1811081633160.1549@nanos.tec.linutronix.de>
From: Thomas Gleixner
> Sent: 08 November 2018 15:36
> On Thu, 8 Nov 2018, Borislav Petkov wrote:
> > And frankly, I don't see why we should be fixing all those. So what if a
> > global function does't have a previous prototype declaration?!
>
> Global function declarations must have a prototype definition, really.
>
> Otherwise you can change the function signature and all callers which use
> the old unchanged prototype are hosed.
I bet there are at least double-figures of real bugs out there.
The next on the list should be -Wwriteable-strings.
Usually just needs a few 'const' sprinkled.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2018-11-09 16:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 1:12 [PATCH v2] x86/cpu: fix prototype warning Yi Wang
2018-11-08 15:03 ` Borislav Petkov
2018-11-08 15:32 ` Borislav Petkov
2018-11-08 15:35 ` Thomas Gleixner
2018-11-08 15:41 ` Borislav Petkov
2018-11-09 16:07 ` David Laight [this message]
2018-11-10 10:51 ` [tip:ras/core] x86/mce: Fix -Wmissing-prototypes warnings tip-bot for Borislav Petkov
2018-11-10 14:16 ` Borislav Petkov
2018-11-12 5:24 ` Ingo Molnar
2018-11-12 12:19 ` Borislav Petkov
2018-11-13 14:22 ` [tip:x86/cleanups] x86/traps: Complete prototype declarations tip-bot for Borislav Petkov
2018-11-14 13:19 ` tip-bot for Borislav Petkov
2018-11-13 14:21 ` [tip:x86/cleanups] x86/mce: Fix -Wmissing-prototypes warnings tip-bot for Borislav Petkov
2018-11-14 13:18 ` tip-bot for Borislav Petkov
2018-11-08 15:47 ` [PATCH v2] x86/cpu: fix prototype warning Michael Matz
2018-11-08 17:22 ` Borislav Petkov
[not found] ` <201811090843126464658@zte.com.cn>
2018-11-09 10:55 ` Borislav Petkov
2018-11-09 11:12 ` Greg KH
2018-11-09 11:41 ` Borislav Petkov
2018-11-09 12:25 ` Greg KH
2018-11-09 22:17 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e5713c2f323453d80bdd2259e3392e5@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=bp@alien8.de \
--cc=davidwang@zhaoxin.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matz@suse.de \
--cc=mingo@redhat.com \
--cc=puwen@hygon.cn \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=wang.yi59@zte.com.cn \
--cc=x86@kernel.org \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).