From: Adrian Hunter <adrian.hunter@intel.com>
To: DooHyun Hwang <dh0421.hwang@samsung.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, ulf.hansson@linaro.org,
robh+dt@kernel.org, axboe@kernel.dk, satyat@google.com,
ebiggers@google.com, gustavoars@kernel.org
Cc: grant.jung@samsung.com, jt77.jang@samsung.com,
junwoo80.lee@samsung.com, jangsub.yi@samsung.com,
sh043.lee@samsung.com, cw9316.lee@samsung.com,
sh8267.baek@samsung.com, wkon.kim@samsung.com
Subject: Re: [PATCH 2/2] mmc: core: Add no single read retries
Date: Wed, 17 Feb 2021 08:00:36 +0200 [thread overview]
Message-ID: <3e6525b5-9cd7-e632-800a-1066c5fa3581@intel.com> (raw)
In-Reply-To: <4035139d-7850-8460-f069-06fc61d13039@intel.com>
On 17/02/21 7:46 am, Adrian Hunter wrote:
> On 17/02/21 7:22 am, DooHyun Hwang wrote:
>> This makes to handle read errors faster by not retrying
>> multiple block read(CMD18) errors with single block reads(CMD17).
>>
>> On some bad SD Cards that have problem with read operations,
>> it is not helpful to retry multiple block read errors with
>> several single block reads, and it is delayed to treat read
>> operations as I/O error as much as retrying single block reads.
>
> If the issue is that it takes too long, then maybe it would be better to get
> mmc_blk_read_single() to give up after a certain amount of time.
>
So that a device property would not be needed I mean. Then everyone would
benefit.
next prev parent reply other threads:[~2021-02-17 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210217053519epcas1p4204253d3af8e1c6d2a5c3acb73eb877f@epcas1p4.samsung.com>
2021-02-17 5:22 ` [PATCH 0/2] mmc: core: add a new property DooHyun Hwang
[not found] ` <CGME20210217053520epcas1p1af462836bd9fc690d99baed0b122d6fd@epcas1p1.samsung.com>
2021-02-17 5:22 ` [PATCH 1/2] dt-bindings: mmc: Add no-single-read-retry property DooHyun Hwang
[not found] ` <CGME20210217053521epcas1p2aa80cae5d52f30c8c8882f44abe8045c@epcas1p2.samsung.com>
2021-02-17 5:22 ` [PATCH 2/2] mmc: core: Add no single read retries DooHyun Hwang
2021-02-17 5:46 ` Adrian Hunter
2021-02-17 6:00 ` Adrian Hunter [this message]
2021-02-17 8:46 ` DooHyun Hwang
2021-03-01 8:23 ` Ulf Hansson
2021-02-17 5:19 [PATCH 0/2] mmc: core: add a new property DooHyun Hwang
[not found] ` <CGME20210217053242epcas1p426e4bdc44270bb6b98eb18f33e66023d@epcas1p4.samsung.com>
2021-02-17 5:19 ` [PATCH 2/2] mmc: core: Add no single read retries DooHyun Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e6525b5-9cd7-e632-800a-1066c5fa3581@intel.com \
--to=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=cw9316.lee@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dh0421.hwang@samsung.com \
--cc=ebiggers@google.com \
--cc=grant.jung@samsung.com \
--cc=gustavoars@kernel.org \
--cc=jangsub.yi@samsung.com \
--cc=jt77.jang@samsung.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=satyat@google.com \
--cc=sh043.lee@samsung.com \
--cc=sh8267.baek@samsung.com \
--cc=ulf.hansson@linaro.org \
--cc=wkon.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).