From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 104B0E7542D for ; Tue, 3 Oct 2023 07:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231504AbjJCHgM (ORCPT ); Tue, 3 Oct 2023 03:36:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230359AbjJCHgK (ORCPT ); Tue, 3 Oct 2023 03:36:10 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2ECEB0 for ; Tue, 3 Oct 2023 00:36:03 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-405361bb94eso6303515e9.0 for ; Tue, 03 Oct 2023 00:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696318562; x=1696923362; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=7UD/AB2S4ZYVLnpGYToE/FYGZFMT1WUw1oYcs+MI0m4=; b=ltJKe5JHNpwanbXuDV5CKhzGlyK9rTJTua1ft4kQDtpmtm8CWQ4SLv1Vly7SOfW9c5 7Y5nSNiREDFRi+RpKo22/wVBrt84T639rIMi+1Ts1sRQcZc8lH5UkzuAAHfFs7TN3AgV 1s3HQ2PTMOE3kP5TDxkmrHK+pafcBVg3naMRhIgMw9WgWggAzCNP26nD+mNNcdGQqODN U4s/X5XOu5l7G4ZycPycA5F87DZT3/PWMpyiww1QUUuGL1wLCrL0jIBm329zREM1nu5s rDKLlKFYwvV7xp47IOMJPbUcoe2V+Q9WeCtwVZM3We+E4o+KYUE8H7FNSLIIbdWK9Bn1 bjYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696318562; x=1696923362; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7UD/AB2S4ZYVLnpGYToE/FYGZFMT1WUw1oYcs+MI0m4=; b=fHNv5+j1swC9l7IokJDzAoYR1GlLVgEnAT+0drUAE08iDJ1XIiQZYHx9c7dDzyjdC3 nNezHDjFic+XaoWqeQ2Zive2DzAZpz02pWpyhmbSSp36kQTb5aJyJEPwZkOXujlqVdN7 rzfUIbkfbVTX6DeFs+13v0zu7LPpp+WZBwrA42Rf39jvOSZmz6YJ1gvwB8ilLGd29a52 USHhZ2slvRKlLSVjMnWDC1AWnMe5Nf5bjqTdpLMVPrcvcqdqZesXvy7VV3k/k5hL8dGG vMMUv2iZn3PO1EkSsXLusdJIZndRsqTlbPhD30ALy3M+eL7WHIeqgjHLunlVmzOq1JQu a7rA== X-Gm-Message-State: AOJu0Yy11Ry40y7188Qoa3W1hY8B6j/nIW58rm6L+2H48yFDAsmnPqb2 GrHke1UQnDpIgyyH85u9gdtuIw== X-Google-Smtp-Source: AGHT+IHfrMd12jZOVbBNYQXDMF8woMAZg0b4WJeiSzKXpx/lbo968fAvntSoS0fq0qv1sKjTmqjuPg== X-Received: by 2002:a05:600c:2116:b0:401:519:c9 with SMTP id u22-20020a05600c211600b00401051900c9mr11917623wml.13.1696318562223; Tue, 03 Oct 2023 00:36:02 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:e31a:fe1c:e925:9858? ([2a01:e0a:982:cbb0:e31a:fe1c:e925:9858]) by smtp.gmail.com with ESMTPSA id p25-20020a7bcc99000000b004063ea92492sm606899wma.22.2023.10.03.00.36.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Oct 2023 00:36:01 -0700 (PDT) Message-ID: <3e69ae4b-5d9e-42ee-a21e-151de8fbb996@linaro.org> Date: Tue, 3 Oct 2023 09:35:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 2/2] arm64: dts: amlogic: add libretech cottonwood support Content-Language: en-US, fr To: Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Kevin Hilman , Da Xue , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org References: <20231002141020.2403652-1-jbrunet@baylibre.com> <20231002141020.2403652-3-jbrunet@baylibre.com> <1j5y3ozvmk.fsf@starbuckisacylon.baylibre.com> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <1j5y3ozvmk.fsf@starbuckisacylon.baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/2023 20:57, Jerome Brunet wrote: > > On Mon 02 Oct 2023 at 18:45, Neil Armstrong wrote: > >>> +&usb3_pcie_phy { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + phy-supply = <&vcc_5v>; >>> + >>> + hub: hub@1 { >>> + compatible = "usb5e3,626"; >>> + reg = <1>; >>> + reset-gpios = <&gpio GPIOC_7 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>; >>> + }; >> >> Not sure the PHY is the right place to put the USB HUB, >> and it's probable the HUB is connected to both the USB2 and USB3 lines > > It is connected to the USB3.0 only > >> so you should have both USB IDs in DT like it'd done for the Odroid-C4: >> >> / { >> ... >> /* USB hub supports both USB 2.0 and USB 3.0 root hub */ >> usb-hub { >> dr_mode = "host"; >> #address-cells = <1>; >> #size-cells = <0>; >> >> /* 2.0 hub on port 1 */ >> hub_2_0: hub@1 { >> compatible = "usb2109,2817"; >> reg = <1>; >> peer-hub = <&hub_3_0>; >> reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>; >> vdd-supply = <&vcc_5v>; >> }; >> >> /* 3.1 hub on port 4 */ >> hub_3_0: hub@2 { >> compatible = "usb2109,817"; >> reg = <2>; >> peer-hub = <&hub_2_0>; >> reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>; >> vdd-supply = <&vcc_5v>; >> }; >> }; >> ... >> }; >> >> if it only has a single USB ID, then it should go under the dwc3 node. > > The usb controller is connected to the PHY and what's coming out of the PHY > goes to the hub. It seems logical to hub the hub under it. > > Why bypass the PHY ? The USB bindings the USB devices nodes should be under the controller's node, not the PHY, see: Documentation/devicetree/bindings/usb/usb-hcd.yaml ... patternProperties: "^.*@[0-9a-f]{1,2}$": description: The hard wired USB devices type: object $ref: /schemas/usb/usb-device.yaml ... and the example. Subnodes aren't allowed in the PHY node. Neil > >> >>> +}; >>> + >>> +&usb { >>> + status = "okay"; >>> +};