From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>, skannan@codeaurora.org
Cc: Evan Green <evgreen@google.com>,
rjw@rjwysocki.net, Viresh Kumar <viresh.kumar@linaro.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
anischal@codeaurora.org, devicetree@vger.kernel.org,
robh@kernel.org, amit.kucheria@linaro.org
Subject: Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver
Date: Sun, 23 Sep 2018 15:05:05 +0530 [thread overview]
Message-ID: <3e6b6874-3560-0ea0-6861-9f47f308e089@codeaurora.org> (raw)
In-Reply-To: <153504951102.28926.11593809590549791317@swboyd.mtv.corp.google.com>
Hello Stephen,
On 8/24/2018 12:08 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2018-08-08 03:15:26)
>>
>>
>> On 8/8/2018 11:52 AM, Stephen Boyd wrote:
>>>>
>>>> Binding describes hardware controllable by the OS. That's the reality.
>>>> Let's not add mandatory clock bindings for clocks that the OS can't do
>>>> anything about.
>>>>
>>>
>>> It seems that you believe clks should only be used to turn on/off and
>>> control rates. That is not the whole truth. Sometimes clks are there
>>> just to express the clk frequencies that are present in the design so
>>> that drivers can figure out what to do.
>>>
>>
>> Stephen,
>>
>> As this clock is not configurable by linux clock drivers and we really
>> do not care the parent src(as mentioned by Saravana) to generate the
>> 300MHz, would it be good to define a fixed rate clock so as to express
>> the HW connectivity & frequency?
>>
>
> As a hack that works great, but why do we need to workaround problems by
> adding a fixed rate clk to DT for this PLL? The PLL is provided by GCC
> node so it should be connected to the GCC node.
>
Please help with review the next patch series which would take the PLL
phandle from DT.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
next prev parent reply other threads:[~2018-09-23 9:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 10:42 [PATCH v7 0/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver Taniya Das
2018-07-24 10:42 ` [PATCH v7 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ Firmware bindings Taniya Das
2018-08-03 23:46 ` Stephen Boyd
2018-08-06 20:54 ` skannan
2018-08-07 11:12 ` Sudeep Holla
2018-08-07 19:24 ` skannan
2018-08-08 2:46 ` Taniya Das
2018-08-08 6:15 ` Stephen Boyd
2018-08-08 8:37 ` Sudeep Holla
2018-07-24 10:42 ` [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver Taniya Das
2018-08-03 19:40 ` Evan Green
2018-08-03 19:52 ` skannan
2018-08-03 22:24 ` Stephen Boyd
2018-08-06 20:46 ` skannan
2018-08-08 6:22 ` Stephen Boyd
2018-08-08 10:15 ` Taniya Das
2018-08-23 18:38 ` Stephen Boyd
2018-09-23 9:35 ` Taniya Das [this message]
2018-08-29 18:01 ` Matthias Kaehlcke
2018-09-23 9:40 ` Taniya Das
2018-09-24 17:02 ` Matthias Kaehlcke
2018-09-09 14:34 ` Amit Kucheria
2018-09-23 9:43 ` Taniya Das
2018-09-10 19:30 ` Matthias Kaehlcke
2018-09-23 9:48 ` Taniya Das
2018-09-24 16:44 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e6b6874-3560-0ea0-6861-9f47f308e089@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=amit.kucheria@linaro.org \
--cc=anischal@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=skannan@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).