* [PATCH net-next] 9p: mark expected switch fall-through
@ 2019-01-23 7:16 Gustavo A. R. Silva
2019-01-23 7:23 ` Dominique Martinet
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-23 7:16 UTC (permalink / raw)
To: Eric Van Hensbergen, Latchesar Ionkov, Dominique Martinet,
David S. Miller
Cc: v9fs-developer, netdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
This patch fixes the following warning:
net/9p/trans_xen.c:514:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
net/9p/trans_xen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
index e2fbf3677b9b..29420ebb8f07 100644
--- a/net/9p/trans_xen.c
+++ b/net/9p/trans_xen.c
@@ -513,7 +513,7 @@ static void xen_9pfs_front_changed(struct xenbus_device *dev,
case XenbusStateClosed:
if (dev->state == XenbusStateClosed)
break;
- /* Missed the backend's CLOSING state -- fallthrough */
+ /* fall through - Missed the backend's CLOSING state */
case XenbusStateClosing:
xenbus_frontend_closed(dev);
break;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] 9p: mark expected switch fall-through
2019-01-23 7:16 [PATCH net-next] 9p: mark expected switch fall-through Gustavo A. R. Silva
@ 2019-01-23 7:23 ` Dominique Martinet
2019-01-23 7:25 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Dominique Martinet @ 2019-01-23 7:23 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Eric Van Hensbergen, Latchesar Ionkov, David S. Miller,
v9fs-developer, netdev, linux-kernel
Gustavo A. R. Silva wrote on Wed, Jan 23, 2019:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> net/9p/trans_xen.c:514:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Sure, taking this to my queue for -next
--
Dominique
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] 9p: mark expected switch fall-through
2019-01-23 7:23 ` Dominique Martinet
@ 2019-01-23 7:25 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-23 7:25 UTC (permalink / raw)
To: Dominique Martinet
Cc: Eric Van Hensbergen, Latchesar Ionkov, David S. Miller,
v9fs-developer, netdev, linux-kernel
On 1/23/19 1:23 AM, Dominique Martinet wrote:
> Gustavo A. R. Silva wrote on Wed, Jan 23, 2019:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> net/9p/trans_xen.c:514:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Sure, taking this to my queue for -next
>
Thanks, Dominique. :)
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-23 7:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-23 7:16 [PATCH net-next] 9p: mark expected switch fall-through Gustavo A. R. Silva
2019-01-23 7:23 ` Dominique Martinet
2019-01-23 7:25 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).