Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver

From: Alex Elder <elder@ieee.org>
To: Markus Elfring <Markus.Elfring@web.de>,
	Ayush Singh <ayushdevel1325@gmail.com>,
	Vaishnav M A <vaishnav@beagleboard.org>,
	devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	lorforlinux@beagleboard.org, greybus-dev@lists.linaro.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Alex Elder <elder@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Conor Dooley <conor+dt@kernel.org>,
	Derek Kiernan <derek.kiernan@amd.com>,
	Dragan Cvetic <dragan.cvetic@amd.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jason Kridner <jkridner@beagleboard.org>,
	Johan Hovold <johan@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Mark Brown <broonie@kernel.org>, Nishanth Menon <nm@ti.com>,
	Rob Herring <robh@kernel.org>,
	Robert Nelson <robertcnelson@beagleboard.org>,
	Tero Kristo <kristo@kernel.org>, Vaishnav M A <vaishnav.a@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver
Date: Mon, 18 Mar 2024 13:41:38 -0500	[thread overview]
Message-ID: <3eb9d5c2-149c-460c-9684-3fdaf946c400@ieee.org> (raw)
In-Reply-To: <4fe6f68a-786c-4e3d-b97d-847d6965d1d3@web.de>

On 3/18/24 12:58 PM, Markus Elfring wrote:
> …
>> +++ b/drivers/misc/mikrobus/mikrobus_core.c
> …
>> +static int mikrobus_pinctrl_setup(struct mikrobus_port *port,
>> +				  struct addon_board_info *board)
>> +{
>> +	int ret;
>> +
>> +	if (!board || board->pin_state[MIKROBUS_PIN_PWM] == MIKROBUS_STATE_PWM)
>> +		ret = mikrobus_pinctrl_select(port, "pwm_default");
>> +	else
>> +		ret = mikrobus_pinctrl_select(port, "pwm_gpio");
> …
> 
> How do you think about to avoid the specification of a bit of duplicate source code here
> by using conditional operator expressions?
> 
> 	ret = mikrobus_pinctrl_select(port,
> 				      ((!board ||
> 					board->pin_state[MIKROBUS_PIN_PWM] == MIKROBUS_STATE_PWM)
> 				      ? "pwm_default"
> 				      : "pwm_gpio"));

No.

It's a complex enough bit of logic without trying to bury
it inside the parameters passed to the function.

					-Alex

> 
> 
> Regards,
> Markus
> 