From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226ic2BR7VVSLY3uD+NM2IR3N9oyDN2DCzJYgBxBEjDfXOiIU9NyNJA29CbPGzwjwwpa6Som ARC-Seal: i=1; a=rsa-sha256; t=1516732990; cv=none; d=google.com; s=arc-20160816; b=dbm8TsS9O0n/u9kpEtM2vo/MYMTTz3lXChqCOrVax6X4TBempr1MmXtlm0irpXPpRU HYU3lJd0/v10lfuuQSQ1ULmLgicdxWvHFSDgjt51CXMd8IW9Omn57SAcomKWaV1aO/bX l/6JygP2F1c/LgKc6gD/1Wk4JOCs7SXaJcJ9dMVI1gAmA79v1N75yRD9+4tnAFM5foOe VCTU7luqQP3GvhLKhFLPGvzx0hR937wc3cRbwih3tWtSCJ6p7YPMiR8CJAg8hVL+GNB4 9QUvUe5SRJr9Cat4ahRoWOESlF46Hc+rpSG4rUAQYKH42V1vYCKlqtQiD8Unh04N/iSw aDjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=UBqLVJcKqbO0kCDOAv3y+ZxFhGYfmCWkObFwOlV2bnk=; b=CQq3ho0vLBmz3T4jbs8AXusoqKuBUqBdrjIgWVGFuQ7RshX1mMkpoz1/6PHmBa/TeL 8zs+zg7sTLCcxyqBnASiTxYFR01Fz8mu7CBgudWXRtqaVC53ufFPLU7cI0WHAi2r9AYI MrDPBrtRsPiIG4uTOgD9bNzUPWSsJ4dL2Y2/vkMhgLuhKXCy+NY41BBobIhZKNTU91P3 sK+VljyyIn8JLGuu/wDCH82hdlMzfo2QCjYGhAgvhS9SkPbZ8J8LnF6uvK8y7Y1hd7hO FWpFiCj8seiOBiHf4wndxqRPfJibJ2g8K7yJFIaN5CRlPkmeO+QcoB3+FbXl50oRSnIr 2ksg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dave.hansen@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=dave.hansen@intel.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of dave.hansen@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=dave.hansen@intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,402,1511856000"; d="scan'208";a="12037366" Subject: Re: [PATCH v2 2/5] x86/cpufeatures: Add Intel feature bits for Speculation Control To: David Woodhouse , arjan@linux.intel.com, tglx@linutronix.de, karahmed@amazon.de, x86@kernel.org, linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com, bp@alien8.de, peterz@infradead.org, pbonzini@redhat.com, ak@linux.intel.com, torvalds@linux-foundation.org, gregkh@linux-foundation.org, thomas.lendacky@amd.com References: <1516726375-25168-1-git-send-email-dwmw@amazon.co.uk> <1516726375-25168-3-git-send-email-dwmw@amazon.co.uk> From: Dave Hansen Message-ID: <3ebee57a-b116-68f6-0421-0640f5e552f5@intel.com> Date: Tue, 23 Jan 2018 10:43:07 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1516726375-25168-3-git-send-email-dwmw@amazon.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590402900695283949?= X-GMAIL-MSGID: =?utf-8?q?1590409811934099108?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 01/23/2018 08:52 AM, David Woodhouse wrote: > > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > index 7b25cf3..0a51070 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -320,6 +320,9 @@ > /* Intel-defined CPU features, CPUID level 0x00000007:0 (EDX), word 18 */ > #define X86_FEATURE_AVX512_4VNNIW (18*32+ 2) /* AVX-512 Neural Network Instructions */ > #define X86_FEATURE_AVX512_4FMAPS (18*32+ 3) /* AVX-512 Multiply Accumulation Single precision */ > +#define X86_FEATURE_SPEC_CTRL (18*32+26) /* Speculation Control (IBRS + IBPB) */ > +#define X86_FEATURE_STIBP (18*32+27) /* Single Thread Indirect Branch Predictors */ > +#define X86_FEATURE_ARCH_CAPABILITIES (18*32+29) /* IA32_ARCH_CAPABILITIES MSR (Intel) */ Should we be adding flags (STIBP) for which we currently have no user in the kernel?