From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE3EC433E0 for ; Fri, 5 Mar 2021 11:00:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4087D6501D for ; Fri, 5 Mar 2021 11:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229616AbhCEK7d (ORCPT ); Fri, 5 Mar 2021 05:59:33 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:51072 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbhCEK7E (ORCPT ); Fri, 5 Mar 2021 05:59:04 -0500 Received: from mail-wr1-f69.google.com ([209.85.221.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI8AV-0001GG-Sd for linux-kernel@vger.kernel.org; Fri, 05 Mar 2021 10:58:52 +0000 Received: by mail-wr1-f69.google.com with SMTP id x9so888935wro.9 for ; Fri, 05 Mar 2021 02:58:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4aJfVlauewtRE5vCynuYGIqgJwZdZisFk3AW2s1txII=; b=SlxOjbfwCRI8jdGATErOfz47M885oMFFZQnIJUUrJ1p8obXpKxIUUBuOh15KLkz9NC EnrnZMVb5GMz05gIlPofnKu2ZBRZgEMtz0A7/LQyOt3MspcOEiYeWAbSI67w6xy6Rs3a 4jlwJsLsCHTXUVYbLCN1KtErVFjFRNA3JoU/vkLmuN8KxqXKSX7IX5RGChBSI78K+pl4 wrPELCika3XOpuhVwhvVnrVglFU9Tuc37Eubdt7tqaRZffFWqlJgeTsOEE2XzwqdI3+M MkOKBa7KYTQHCsHYTptuPHtInzJibRxE1OeFHGOm4qA2fEkl8wRQtit8fO3FiDc3f7Wd Vs6A== X-Gm-Message-State: AOAM5302dZdnCtEdjVs4Ca220NLYBCrArZ3orR6QL0xYSs8lUQRRjcK9 TmWq2gpzht4PuOt4fm3IqWZ0E/dA0u8+y6/0lH4kr/jZeBEx6ckY42iCfcmKpVJ097gEb4Q1nyK cHnqXvx2oiLCJyremuDA9rmPZ90vK2fCnt6wd3Iq5qQ== X-Received: by 2002:a7b:cb99:: with SMTP id m25mr8423390wmi.64.1614941931429; Fri, 05 Mar 2021 02:58:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmQw4qIFRa6N+eh+U12JE4vYPax7TgkB7xnzrasYQiJvSoeqLGr8BCj354zBBg7bPpy0fgIA== X-Received: by 2002:a7b:cb99:: with SMTP id m25mr8423363wmi.64.1614941931318; Fri, 05 Mar 2021 02:58:51 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id h2sm4309640wrq.81.2021.03.05.02.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:58:51 -0800 (PST) Subject: Re: [RFT PATCH v3 24/27] tty: serial: samsung_tty: Add support for Apple UARTs To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-25-marcan@marcan.st> From: Krzysztof Kozlowski Message-ID: <3ed6840e-1c12-4145-c2d5-cb05cac156e9@canonical.com> Date: Fri, 5 Mar 2021 11:58:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304213902.83903-25-marcan@marcan.st> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2021 22:38, Hector Martin wrote: > Apple SoCs are a distant descendant of Samsung designs and use yet > another variant of their UART style, with different interrupt handling. > > In particular, this variant has the following differences with existing > ones: > > * It includes a built-in interrupt controller with different registers, > using only a single platform IRQ > > * Internal interrupt sources are treated as edge-triggered, even though > the IRQ output is level-triggered. This chiefly affects the TX IRQ > path: the driver can no longer rely on the TX buffer empty IRQ > immediately firing after TX is enabled, but instead must prime the > FIFO with data directly. > > Signed-off-by: Hector Martin > --- > drivers/tty/serial/Kconfig | 2 +- > drivers/tty/serial/samsung_tty.c | 238 +++++++++++++++++++++++++++++-- > include/linux/serial_s3c.h | 16 +++ > 3 files changed, 247 insertions(+), 9 deletions(-) > Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof