From: Paolo Bonzini <pbonzini@redhat.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@redhat.com>,
"x86@kernel.org" <x86@kernel.org>, Dave Young <dyoung@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Matt Fleming <matt.fleming@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes()
Date: Wed, 7 Sep 2016 13:20:18 +0200 [thread overview]
Message-ID: <3eea073a-b271-54b7-1eec-e841e0f4bdf9@redhat.com> (raw)
In-Reply-To: <f9edcf05-482e-dfbb-b661-c070ee1debf4@users.sourceforge.net>
On 07/09/2016 13:17, SF Markus Elfring wrote:
>>> Are you looking for further possibilities to improve the involved
>>> source code search patterns?
>>
>> Why are you not answering the simple question that was asked?
>
> I find that I answered it to some degree.
>
> It can be that you do not really like the kind of answer that I chose
> a moment ago.
> But I guess that a more pleasing (and complete) answer can become
> another software development challenge as you might know already.
>
> Would the following script (for the semantic patch language)
> be useful enough for further development considerations?
>
> usage_of_kmalloc_array1-excerpt2.cocci:
> @replacement2@
> expression count, pointer, target;
> @@
> target =
> - kmalloc(sizeof(*pointer) * (count)
> + kmalloc_array(count, sizeof(*pointer)
> , ...);
Why don't you include the _exact_ script that you run? That's the only
possible correct answer.
Paolo
next prev parent reply other threads:[~2016-09-07 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 20:23 [PATCH] x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() SF Markus Elfring
2016-09-06 21:49 ` Kees Cook
2016-09-07 7:49 ` SF Markus Elfring
2016-09-07 10:36 ` Paolo Bonzini
2016-09-07 11:17 ` SF Markus Elfring
2016-09-07 11:20 ` Paolo Bonzini [this message]
2016-09-07 11:45 ` SF Markus Elfring
2016-09-07 16:23 ` Kees Cook
2016-09-07 16:37 ` Joe Perches
2016-09-07 17:01 ` Kees Cook
2016-09-07 16:55 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eea073a-b271-54b7-1eec-e841e0f4bdf9@redhat.com \
--to=pbonzini@redhat.com \
--cc=dyoung@redhat.com \
--cc=elfring@users.sourceforge.net \
--cc=hpa@zytor.com \
--cc=julia.lawall@lip6.fr \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).