From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A96C71130 for ; Mon, 15 Oct 2018 12:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94A482064A for ; Mon, 15 Oct 2018 12:38:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94A482064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727000AbeJOUXR (ORCPT ); Mon, 15 Oct 2018 16:23:17 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58888 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726870AbeJOUXP (ORCPT ); Mon, 15 Oct 2018 16:23:15 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 2980ACBDE9BFC; Mon, 15 Oct 2018 20:38:06 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.399.0; Mon, 15 Oct 2018 20:38:02 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: clear cold data flag if IO is not counted To: Jaegeuk Kim , , References: <20181010212217.52289-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <3f08031e-d195-5bc1-67e1-f3b6eab3506b@huawei.com> Date: Mon, 15 Oct 2018 20:38:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181010212217.52289-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/10/11 5:22, Jaegeuk Kim wrote: > If we clear the cold data flag out of the writeback flow, we can miscount > -1 by end_io. I didn't get it, which count do you mean? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/data.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 29a9d3b8f709..4102799b5558 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -2636,10 +2636,6 @@ static int f2fs_set_data_page_dirty(struct page *page) > if (!PageUptodate(page)) > SetPageUptodate(page); > > - /* don't remain PG_checked flag which was set during GC */ > - if (is_cold_data(page)) > - clear_cold_data(page); > - > if (f2fs_is_atomic_file(inode) && !f2fs_is_commit_atomic_write(inode)) { > if (!IS_ATOMIC_WRITTEN_PAGE(page)) { > f2fs_register_inmem_page(inode, page); >