From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EAFCC433E0 for ; Fri, 5 Feb 2021 07:14:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FFCF64FB7 for ; Fri, 5 Feb 2021 07:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231425AbhBEHOW (ORCPT ); Fri, 5 Feb 2021 02:14:22 -0500 Received: from marcansoft.com ([212.63.210.85]:59618 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231364AbhBEHMo (ORCPT ); Fri, 5 Feb 2021 02:12:44 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 857B5423AD; Fri, 5 Feb 2021 07:11:55 +0000 (UTC) To: Arnd Bergmann List-Id: Cc: SoC Team , Linux ARM , Marc Zyngier , Rob Herring , "linux-kernel@vger.kernel.org" , DTML , Olof Johansson , Ard Biesheuvel References: <20210204203951.52105-1-marcan@marcan.st> <20210204203951.52105-19-marcan@marcan.st> From: Hector Martin 'marcan' Subject: Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree Message-ID: <3f2001f0-4a90-645e-d016-03907228dc7a@marcan.st> Date: Fri, 5 Feb 2021 16:11:53 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: es-ES Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/02/2021 08.08, Arnd Bergmann wrote: > On Thu, Feb 4, 2021 at 10:44 PM Hector Martin 'marcan' wrote: >> On 05/02/2021 06.29, Arnd Bergmann wrote: >>> On Thu, Feb 4, 2021 at 9:39 PM Hector Martin wrote: >>> >>> We tend to split the dts file into one file per SoC and one for the >>> specific board. I guess in this case the split can be slightly different, >>> but it does feel better to be prepared for sharing a lot of the contents >>> between the different products. >>> >>> In most cases, you'd want the 'aliases' and 'chosen' nodes to be >>> in the board specific file. >> >> I thought about that, but wasn't sure if splitting it up at this early >> stage made much sense since I'm not sure what the split should be, given >> all supported hardware is the same for all 3 released devices. >> >> I'm happy to throw the aliases/chosen nodes into board specific files if >> you think that's a good starting point. Perhaps /memory too? Those >> properties are filled in/patched by the bootloader anyway... > > Yes, I think that would help make it more consistent with other > platforms even if we don't care too much here. Ack, I'll split it up for v2. > We don't really have overlays in the kernel sources (yet), though it > is something that keeps coming up. For the moment, I'd just > assume you can have one .dts file for each thing you want to > support and keep the shared bits in .dtsi files. No problem. We'll experiment with overlays in m1n1 and see how that goes. One thing I wanted to ask: is there some kind of "experimental" policy for DT bindings? At early platform bring-up stages it seems like it could be valuable to allow for breaking DT changes while we flesh out the details (this is especially true of a reverse engineered platform like this, where we don't have knowledge of all the hardware details a priori). The dozen or so users we might have at this stage obviously won't complain too much :) -- Hector Martin "marcan" (marcan@marcan.st) Public Key: https://mrcn.st/pub