From: Shuah Khan <shuah@kernel.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Bamvor Zhang <bamv2005@gmail.com>,
brgl@bgdev.pl, Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
aarcange@redhat.com, linux-kbuild@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v4] selftests: add headers_install to lib.mk
Date: Mon, 6 Aug 2018 11:03:54 -0600 [thread overview]
Message-ID: <3f332e65-0b33-9952-6aba-f9c8953a1f26@kernel.org> (raw)
In-Reply-To: <CADYN=9LSA60E4mFwrbeY-RGi4kZV6hO0ygz0-C6QB3+KKaoxQg@mail.gmail.com>
Hi Anders,
On 07/25/2018 10:08 AM, Anders Roxell wrote:
> On Tue, 24 Jul 2018 at 19:11, Shuah Khan <shuah@kernel.org> wrote:
>>
>> On 07/23/2018 02:49 PM, Anders Roxell wrote:
>>> On Thu, 7 Jun 2018 at 13:09, Anders Roxell <anders.roxell@linaro.org> wrote:
>>>>
>>>> If the kernel headers aren't installed we can't build all the tests.
>>>> Add a new make target rule 'khdr' in the file lib.mk to generate the
>>>> kernel headers and that gets include for every test-dir Makefile that
>>>> includes lib.mk If the testdir in turn have its own sub-dirs the
>>>> top_srcdir needs to be set to the linux-rootdir to be able to generate
>>>> the kernel headers.
>>>>
>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>>> Reviewed-by: Fathi Boudra <fathi.boudra@linaro.org>
>>>> ---
>>>> Makefile | 14 +-------------
>>>> scripts/subarch.include | 13 +++++++++++++
>>>> tools/testing/selftests/android/Makefile | 2 +-
>>>> tools/testing/selftests/android/ion/Makefile | 2 ++
>>>> tools/testing/selftests/futex/functional/Makefile | 1 +
>>>> tools/testing/selftests/gpio/Makefile | 7 ++-----
>>>> tools/testing/selftests/kvm/Makefile | 7 ++-----
>>>> tools/testing/selftests/lib.mk | 12 ++++++++++++
>>>> tools/testing/selftests/net/Makefile | 1 +
>>>> .../selftests/networking/timestamping/Makefile | 1 +
>>>> tools/testing/selftests/vm/Makefile | 4 ----
>>>> 11 files changed, 36 insertions(+), 28 deletions(-)
>>>> create mode 100644 scripts/subarch.include
>>>>
>>>> diff --git a/Makefile b/Makefile
>>>> index 6b9aea95ae3a..8050072300fa 100644
>>>> --- a/Makefile
>>>> +++ b/Makefile
>>>> @@ -286,19 +286,7 @@ KERNELRELEASE = $(shell cat include/config/kernel.release 2> /dev/null)
>>>> KERNELVERSION = $(VERSION)$(if $(PATCHLEVEL),.$(PATCHLEVEL)$(if $(SUBLEVEL),.$(SUBLEVEL)))$(EXTRAVERSION)
>>>> export VERSION PATCHLEVEL SUBLEVEL KERNELRELEASE KERNELVERSION
>>>>
>>>> -# SUBARCH tells the usermode build what the underlying arch is. That is set
>>>> -# first, and if a usermode build is happening, the "ARCH=um" on the command
>>>> -# line overrides the setting of ARCH below. If a native build is happening,
>>>> -# then ARCH is assigned, getting whatever value it gets normally, and
>>>> -# SUBARCH is subsequently ignored.
>>>> -
>>>> -SUBARCH := $(shell uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ \
>>>> - -e s/sun4u/sparc64/ \
>>>> - -e s/arm.*/arm/ -e s/sa110/arm/ \
>>>> - -e s/s390x/s390/ -e s/parisc64/parisc/ \
>>>> - -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
>>>> - -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ \
>>>> - -e s/riscv.*/riscv/)
>>>> +include scripts/subarch.include
>>
>> What is the reason for this SUBARCH block move to to scripts/subarch.include?
>> Is this necessary for adding headers install dependency to lib.mk?
>
> This is needed to create headers for cross build.
>
I am sorry for the delay on this patch. I am going to get this into 4.19.
If anybody has objections, please let me.
Anders! Will be able to rebase the patch and send me the latest. I think
I have Acks from kvm, android, and vm so far.
thanks,
-- Shuah
next prev parent reply other threads:[~2018-08-06 17:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 10:23 [PATCH] selftests: add headers_install to lib.mk Anders Roxell
2018-04-13 9:03 ` [PATCH v2] " Anders Roxell
2018-05-14 11:58 ` [PATCH v3] " Anders Roxell
2018-05-14 17:16 ` Paolo Bonzini
2018-05-14 18:44 ` Mike Rapoport
2018-05-14 19:20 ` Daniel Borkmann
2018-06-07 11:07 ` Anders Roxell
2018-06-07 11:09 ` [PATCH v4] " Anders Roxell
2018-07-23 20:49 ` Anders Roxell
2018-07-24 17:10 ` Shuah Khan
2018-07-25 16:08 ` Anders Roxell
2018-08-06 17:03 ` Shuah Khan [this message]
2018-08-07 2:32 ` Masahiro Yamada
2018-08-08 10:44 ` Anders Roxell
2019-01-04 13:15 ` Geert Uytterhoeven
2018-08-09 8:04 ` [PATCH v5] " Anders Roxell
2018-09-04 10:47 ` [PATCH v6] " Anders Roxell
2018-09-05 14:13 ` Shuah Khan
2018-09-28 4:52 ` Michael Ellerman
2018-09-28 13:52 ` Shuah Khan
2018-10-02 14:12 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f332e65-0b33-9952-6aba-f9c8953a1f26@kernel.org \
--to=shuah@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=bamv2005@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).