From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C87DBC433EF for ; Sun, 21 Nov 2021 12:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238081AbhKUMV0 (ORCPT ); Sun, 21 Nov 2021 07:21:26 -0500 Received: from ciao.gmane.io ([116.202.254.214]:37802 "EHLO ciao.gmane.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238008AbhKUMVY (ORCPT ); Sun, 21 Nov 2021 07:21:24 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1molnW-0003bY-8F for linux-kernel@vger.kernel.org; Sun, 21 Nov 2021 13:18:18 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: linux-kernel@vger.kernel.org From: Christophe JAILLET Subject: Re: [PATCH linux-next] drm/i915/request: Remove unused variables Date: Sun, 21 Nov 2021 13:18:09 +0100 Message-ID: <3f420d7d-2f9e-c7e2-e5ac-8200e87781cb@wanadoo.fr> References: <20211121101309.23577-1-yong.yiran@zte.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20211121101309.23577-1-yong.yiran@zte.com.cn> Content-Language: en-US Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 21/11/2021 à 11:13, cgel.zte@gmail.com a écrit : > From: yong yiran > > The clang_analyzer complains as follows: > drivers/gpu/drm/i915/i915_request.c:2119:2 warning: > Value stored to 'x' is never read > > Reported-by: Zeal Robot > Signed-off-by: yong yiran > --- > drivers/gpu/drm/i915/i915_request.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c > index 820a1f38b271..5e4420f461e9 100644 > --- a/drivers/gpu/drm/i915/i915_request.c > +++ b/drivers/gpu/drm/i915/i915_request.c > @@ -2047,7 +2047,6 @@ void i915_request_show(struct drm_printer *m, > { > const char *name = rq->fence.ops->get_timeline_name((struct dma_fence *)&rq->fence); > char buf[80] = ""; > - int x = 0; > > /* > * The prefix is used to show the queue status, for which we use > @@ -2079,8 +2078,6 @@ void i915_request_show(struct drm_printer *m, > * from the lists > */ > > - x = print_sched_attr(&rq->sched.attr, buf, x, sizeof(buf)); > - Seriously? CJ > drm_printf(m, "%s%.*s%c %llx:%lld%s%s %s @ %dms: %s\n", > prefix, indent, " ", > queue_status(rq), >