From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: luca abeni <luca.abeni@santannapisa.it>, linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH 1/4] sched/sched.h: remove duplicate prototype of __dl_clear_params()
Date: Fri, 8 Sep 2017 10:33:46 +0200 [thread overview]
Message-ID: <3f4582ad-d3ee-7094-ba31-bdaf0c1ee9e4@redhat.com> (raw)
In-Reply-To: <1504778971-13573-2-git-send-email-luca.abeni@santannapisa.it>
Hi,
I wonder if a commit log, even an one line comment, explaining that this
function was already declared in the file could help to understand this
patch...
But, the patch is so trivial... that... not sure it is worth... anyway...
On 09/07/2017 12:09 PM, luca abeni wrote:
> Signed-off-by: luca abeni <luca.abeni@santannapisa.it>
Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
-- Daniel
> ---
> kernel/sched/sched.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 1043c8b..0b93e4b 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -255,7 +255,6 @@ extern int sched_dl_overflow(struct task_struct *p, int policy,
> extern void __setparam_dl(struct task_struct *p, const struct sched_attr *attr);
> extern void __getparam_dl(struct task_struct *p, struct sched_attr *attr);
> extern bool __checkparam_dl(const struct sched_attr *attr);
> -extern void __dl_clear_params(struct task_struct *p);
> extern bool dl_param_changed(struct task_struct *p, const struct sched_attr *attr);
> extern int dl_task_can_attach(struct task_struct *p,
> const struct cpumask *cs_cpus_allowed);
>
next prev parent reply other threads:[~2017-09-08 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 10:09 [PATCH 0/4] SCHED_DEADLINE fixes and cleanups luca abeni
2017-09-07 10:09 ` [PATCH 1/4] sched/sched.h: remove duplicate prototype of __dl_clear_params() luca abeni
2017-09-08 8:33 ` Daniel Bristot de Oliveira [this message]
2017-10-10 10:55 ` [tip:sched/core] sched/headers: Remove " tip-bot for luca abeni
2017-09-07 10:09 ` [PATCH 2/4] sched/deadline: fix switching to -deadline luca abeni
2017-10-10 10:56 ` [tip:sched/core] sched/deadline: Fix " tip-bot for Luca Abeni
2017-09-07 10:09 ` [PATCH 3/4] sched/deadline: rename __dl_clear() to __dl_sub() luca abeni
2017-09-08 8:26 ` Daniel Bristot de Oliveira
2017-10-10 10:56 ` [tip:sched/core] sched/deadline: Rename " tip-bot for Peter Zijlstra
2017-09-07 10:09 ` [PATCH 4/4] sched/deadline: use C bitfields for the state flags luca abeni
2017-09-08 8:24 ` Daniel Bristot de Oliveira
2017-10-10 10:57 ` [tip:sched/core] sched/deadline: Use " tip-bot for luca abeni
2017-10-02 8:18 ` [PATCH 0/4] SCHED_DEADLINE fixes and cleanups Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f4582ad-d3ee-7094-ba31-bdaf0c1ee9e4@redhat.com \
--to=bristot@redhat.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).