From: Brijesh Singh <brijesh.singh@amd.com>
To: Peter Gonda <pgonda@google.com>, kvm@vger.kernel.org
Cc: brijesh.singh@amd.com, Lars Bull <larsbull@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
David Rientjes <rientjes@google.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] KVM, SEV: Add support for SEV local migration
Date: Mon, 12 Jul 2021 16:09:14 -0500 [thread overview]
Message-ID: <3f4a1b67-f426-5101-1e07-9f948e529d34@amd.com> (raw)
In-Reply-To: <20210621163118.1040170-3-pgonda@google.com>
On 6/21/21 11:31 AM, Peter Gonda wrote:
> + if (!sev_guest(kvm))
> + return -ENOTTY;
> +
> + if (sev->es_active)
> + return -EPERM;
> +
> + if (sev->info_token != 0)
> + return -EEXIST;
> +
> + if (copy_from_user(¶ms, (void __user *)(uintptr_t)argp->data,
> + sizeof(params)))
> + return -EFAULT;
> +
> + entry = kzalloc(sizeof(*entry), GFP_KERNEL);
> + if (!entry)
> + return -ENOMEM;
> +
> + entry->asid = sev->asid;
> + entry->handle = sev->handle;
> + entry->pages_locked = sev->pages_locked;
> + entry->misc_cg = sev->misc_cg;
> +
> + INIT_LIST_HEAD(&entry->regions_list);
> + list_replace_init(&sev->regions_list, &entry->regions_list);
I believe the entry->regions_list will be NULL if the command is called
before the memory regions are registered. The quesiton is, do you need
to check whether for a valid sev->handle (i.e, LAUNCH_START is done)?
> +
> /* Userspace wants to query session length. */
> static int
> __sev_send_start_query_session_length(struct kvm *kvm, struct kvm_sev_cmd *argp,
> @@ -1513,6 +1711,18 @@ int svm_mem_enc_op(struct kvm *kvm, void __user *argp)
> goto out;
> }
>
> + /*
> + * If this VM has started exporting its SEV contents to another VM,
> + * it's not allowed to do any more SEV operations that may modify the
> + * SEV state.
> + */
> + if (to_kvm_svm(kvm)->sev_info.info_token &&
> + sev_cmd.id != KVM_SEV_DBG_ENCRYPT &&
> + sev_cmd.id != KVM_SEV_DBG_DECRYPT) {
> + r = -EPERM;
> + goto out;
> + }
Maybe move this check in a function so that it can later extended for
SEV-SNP (cmd ids for the debug is different).
Something like:
static bool is_local_mig_active(struct kvm *)
{
....
}
Once the migration range hypercall is merged, we also need to preserve
any metadata memory maintained by KVM for the unencrypted ranges.
-Brijesh
next prev parent reply other threads:[~2021-07-12 21:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 16:31 [PATCH 0/3] Add AMD SEV and SEV-ES local migration support Peter Gonda
2021-06-21 16:31 ` [PATCH 1/3] KVM, SEV: Refactor out function for unregistering encrypted regions Peter Gonda
2021-07-12 20:05 ` Brijesh Singh
2021-07-13 21:40 ` Sean Christopherson
2021-07-13 23:18 ` Marc Orr
2021-06-21 16:31 ` [PATCH 2/3] KVM, SEV: Add support for SEV local migration Peter Gonda
2021-07-12 21:09 ` Brijesh Singh [this message]
2021-07-13 20:12 ` Peter Gonda
2021-07-13 22:12 ` Sean Christopherson
2021-07-13 23:24 ` Marc Orr
2021-06-21 16:31 ` [PATCH 3/3] KVM, SEV: Add support for SEV-ES " Peter Gonda
2021-07-13 18:41 ` Brijesh Singh
2021-07-13 22:21 ` Sean Christopherson
2021-07-13 23:25 ` Marc Orr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f4a1b67-f426-5101-1e07-9f948e529d34@amd.com \
--to=brijesh.singh@amd.com \
--cc=bp@alien8.de \
--cc=dgilbert@redhat.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=larsbull@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).