From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965617AbcIWKzT (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Sep 2016 06:55:19 -0400
Received: from mout.web.de ([212.227.15.4]:56841 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757451AbcIWKzR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Sep 2016 06:55:17 -0400
Subject: Re: GPU-DRM-TILCDC: Less function calls in
 tilcdc_convert_slave_node() after error detection
To: Jyri Sarha <jsarha@ti.com>
References: <566ABCD9.1060404@users.sourceforge.net>
 <2f3f7ad7-16a0-1dfb-d073-0d993cd767ee@users.sourceforge.net>
 <0be7fee0-64f7-fa02-0337-51376677343e@users.sourceforge.net>
 <e9b443c7-2947-46d5-462f-58c175b774bc@ti.com>
 <d9b20442-3f84-82bd-d600-e3045a21da99@users.sourceforge.net>
 <b22e0060-503d-ac31-fe8c-8a356145bec8@ti.com>
 <d9ce49fe-4aab-2138-3ecc-86fa825120fa@users.sourceforge.net>
 <cf250b58-8747-2d43-71ad-e211938cbcde@ti.com>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <3f4cbe32-aa0b-0123-2f1c-f34a7f160797@users.sourceforge.net>
Date: Fri, 23 Sep 2016 12:55:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <cf250b58-8747-2d43-71ad-e211938cbcde@ti.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:oPEOdwBAzaKPv5CSPZGp0474niS6rXDxP3weU4EV/7Jg0JaObRR
 nqheZxcGkyvtHsxbXCG4vCmEBFScep1Ly8mG2yIR+rKa9ymuuTyqPdDv3KYI7vm/MQAX3ww
 k2JV2SWetCVuktrHIWaqnOoTTOGgiiqOUkFyUok0+wiXgNj6iXLvWa1f728s81z+RwiEr4E
 g4HDHQV+I7CoN2Q28uljg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:9smbaPYKlew=:5lYdFqhhDikJAwIeg5JWNl
 SLP+YMafBziBEKdJYHvmYISauEq0H5TwIKn3KSxQq6aJgmM890w63lcD2JPEdsm7bVdP61WCq
 mnUjd0uCvKL6CGGj63LBZ3A3h2Ru0aZSZdUvT8PeV1T5/3o5nwXYvyy+5AFcC5R140kFUK74N
 R65ukcS5S+NwNgJC1CLUbwmxjaxLYScp1xJVHHtL95Njewt3sbZcxgUwKm2UbXTLxapbncx3A
 npPl4poh/zeI2h4DR2N6JmF8tdJ9vwjue6YK8dnRrxzGVMeLG538ot/8EXIg5y/0DGhJxh79e
 eANtUZ9tWfwwrUDI5qyfcQ6tgaL9Mx4BHdjnaFmdAJHdrYkDcLBj9tuCgdnMMqHsIQEOTYlwh
 UcNgQolSjKTCHg/fmKlZleghlyZ8Bi7WTJ9RWtvI3KeDuKTqRvQ9Z1uIutylEQcGN7SBxRKGO
 EU3c7u+6+eyQlv+2oKWL6e/fI7dm2pOVYfmGk5Xw01dheaxDBj1LJrAXSdw34Q+9njua4vQcP
 G8Q8KTG5HYVmEyiqDBOQqO/0ebXo5VlQbOnUOgu9CjIHBSrdm6yH3PzGe5xxBb5KyZfbspHvW
 RLg8U5FDIPTjyswLN+48R8DZt/TzIsCnMMlpAiJ4DOm/vecxqdYuq6V/2AX8wbAgu+/5/URfn
 G5eU2q37A9Vxz52Tmewc9CkEma54eXKHeBhcyKYMsPT6MH5hv7BrS5zTuLQZ+eBanKECyPz6u
 sjHTjuYA9tB2VfjHV2pI+2Dp2DCUgwywj7zKIkeX21EFXWI2H+lspEDtkcjyYAfY6oN/P5Y7p
 93oMaLw
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> A special view on software simplicity can also lead to questionable intermediate
>> function implementation, can't it?
> 
> I don't really follow. But in any case I do not see anything
> questionable in the current tilcdc_convert_slave_node() implementation.

I identified update candidates there like the following.

1. Delayed checking for null pointers
…
	if (!slave || !of_device_is_available(lcdc))
…

2. Usage of a single jump label for (too many?) cases
…
		goto out;
…

   Can the corresponding exception handling become also a bit more efficient?


>> Would you like to care a bit more for efficiency and software correctness
>> around the discussed exception handling?
> 
> No, I would not.

Thanks for this information.

I hope that the software situation can also be improved around
this design aspect somehow.


> For the moment I have more important tasks to do.

I know also that various open issues are competing for your software
development attention as usual.

Regards,
Markus