From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED899C432BE for ; Sun, 29 Aug 2021 15:04:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D223060F42 for ; Sun, 29 Aug 2021 15:04:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235528AbhH2PE7 (ORCPT ); Sun, 29 Aug 2021 11:04:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235522AbhH2PE5 (ORCPT ); Sun, 29 Aug 2021 11:04:57 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0647C061575 for ; Sun, 29 Aug 2021 08:04:05 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id x2-20020a1c7c02000000b002e6f1f69a1eso12859419wmc.5 for ; Sun, 29 Aug 2021 08:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=dx6YBc7me/tNxvWQQhiRH8PX3cEFwDzBP2xfLMTDAbo=; b=kMJeKSGuVXUzAC2feI9RJPBmrnkQlr0o3IIXUIqSllXLz+cCY/0Rn663qBZXKe6B1O fOnm3Fah6T0BNcO/ll0wGo83e2KUKLa4o+kG/uQI4j8WPc2Q0obtgriySqd+ygEm5dG2 tKmAdaBqyeU3U4+wzsRIWF7Ae3zTTFo4QF9jZXzCXjr3zbdfTo5dbJ0FDI/yNIlVWycQ AofWeiY+luCwHrwviUyjiB1Q61XsAiK4iPPaxg5+hno2QRhDUGnxnb5LnK4dAYrC5pBb oDwa+iLGOls1Tfwkrx7S/ToPja3Aag+5Uv2SxV5mUWCWL2qrvGr/HEMLQo/udPo7n/8H HgPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dx6YBc7me/tNxvWQQhiRH8PX3cEFwDzBP2xfLMTDAbo=; b=PmYRer5mmyCsuMyHKe5/2tZ2EMtRCQ3InGtV6T0yeS76jAL32si29FVLHEMsmmXNc/ Vx7qTKtCAkH8jr/hT/dG0NpRVaHAM4EjKujz+CA4iYg3LpV+lBh5KqpQ8OTrXxsj0aeI dBkrvR5xCdh5hYPtZaW4DpqCJYFsQnVJ+gwgDFIF57CAQ+T860Hv4bdDBtymULtOrIDN mchRCoW/rtcvXIuLg19YT2qU9E3089/fw0x9ZHfW0SkqNvM+1rO2qpfaUuYUdtAhJc/x mC235oyMmH6rSUungw5SNEiajibQAeDeA5Z3W6g7s2yjXHUat6QFdtKYoB/fsnbpAN/X HInA== X-Gm-Message-State: AOAM531coQohx+yepZdfOW+6/KH4bgDurlndgsN5vPyTylUq4fzZ/e2/ aymO9VsBnBe7JLL1SZkDAlc= X-Google-Smtp-Source: ABdhPJxbo/RS6HSasHPE2utTSn9O0bQvJtekD7CsR6csw19GXYGgq7pTzh31rlc1gic4CsmXY38Taw== X-Received: by 2002:a05:600c:22c3:: with SMTP id 3mr4644512wmg.133.1630249444276; Sun, 29 Aug 2021 08:04:04 -0700 (PDT) Received: from ?IPV6:2a02:8108:96c0:3b88::16fa? ([2a02:8108:96c0:3b88::16fa]) by smtp.gmail.com with UTF8SMTPSA id r20sm13119780wrr.47.2021.08.29.08.04.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Aug 2021 08:04:03 -0700 (PDT) Message-ID: <3f63d7e1-0eb4-21c0-49eb-262cdadf0e87@gmail.com> Date: Sun, 29 Aug 2021 17:04:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.1 Subject: Re: [PATCH 0/3] staging: r8188eu: cleanup c2h_handler code Content-Language: en-US To: Phillip Potter , gregkh@linuxfoundation.org Cc: fmdefrancesco@gmail.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210828212453.898-1-phil@philpotter.co.uk> From: Michael Straube In-Reply-To: <20210828212453.898-1-phil@philpotter.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/28/21 23:24, Phillip Potter wrote: > This small patch set cleans up the c2h_handler code in the HAL layer > of the driver. In r8188eu, this field of struct hal_ops, is not even > used, so dependent code has always returned _FAIL. For this reason, we > should remove this function pointer field, and the wrapper function > which checks it. This is done in stages by this set, and helps get > the driver closer to the pointer where the HAL layer is > deleted/integrated as necessary and no longer a separate entity. > > Phillip Potter (3): > staging: r8188eu: remove c2h_handler field from struct hal_ops > staging: r8188eu: simplify c2h_evt_hdl function > staging: r8188eu: remove rtw_hal_c2h_handler function > > drivers/staging/r8188eu/core/rtw_cmd.c | 23 +++------------------- > drivers/staging/r8188eu/hal/hal_intf.c | 9 --------- > drivers/staging/r8188eu/include/hal_intf.h | 4 ---- > 3 files changed, 3 insertions(+), 33 deletions(-) > Thanks for your patches Phillip. Looks good to me and I've built and runtime tested this series with Inter-Tech DMG-02, so... Acked-by: Michael Straube Thanks, Michael