linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: Meelis Roos <mroos@linux.ee>,
	Thomas Gleixner <tglx@linutronix.de>,
	David Woodhouse <dwmw@amazon.co.uk>
Cc: LKML <linux-kernel@vger.kernel.org>, yamada.masahiro@socionext.com
Subject: Re: Compiling with old gcc breaks when CONFIG_RETPOLINE is off
Date: Wed, 5 Dec 2018 09:30:07 +0800	[thread overview]
Message-ID: <3f72d5fa-cfed-e1a0-4f6c-90f8d1de1ace@oracle.com> (raw)
In-Reply-To: <6eeee8da-82ac-f527-9278-7ebcc8756ea1@linux.ee>

Hi Meelis,

Could you try below change? It force syncconfig for  any 'make *config"

so that autoconf.h and auto.conf are always updated.

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 98e0c7a..802875b 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -38,7 +38,7 @@ enum input_mode {

  static int indent = 1;
  static int tty_stdio;
-static int sync_kconfig;
+static int sync_kconfig = 1;
  static int conf_cnt;
  static char line[PATH_MAX];
  static struct menu *rootEntry;
@@ -506,11 +506,11 @@ int main(int ac, char **av)
                          * Suppress distracting "configuration written 
to ..."
                          */
                         conf_set_message_callback(NULL);
-                       sync_kconfig = 1;
                         break;
                 case defconfig:
                 case savedefconfig:
                         defconfig_file = optarg;
+                       sync_kconfig = 0;
                         break;
                 case randconfig:
                 {
@@ -537,13 +537,15 @@ int main(int ac, char **av)
                         srand(seed);
                         break;
                 }
+               case listnewconfig:
+                       sync_kconfig = 0;
+                       /* fall through */
                 case oldaskconfig:
                 case oldconfig:
                 case allnoconfig:
                 case allyesconfig:
                 case allmodconfig:
                 case alldefconfig:
-               case listnewconfig:
                 case olddefconfig:
                         break;
                 case '?':

Thanks

Zhenzhong

On 2018/12/4 17:58, Meelis Roos wrote:
> Just tried 4.20-rc5 on an old K6-2 PC with gcc 5.3.1, got an error 
> about non-retpoline compiler,
> turned CONFIG_RETPOLINE off and retried.
>
> To my surprise, compilation still breaks with
> arch/x86/Makefile:224: *** You are building kernel with non-retpoline 
> compiler, please update your compiler..  Stop.
>
> As I read the Makefile, it should error only when CONFIG_RETPOLINE is 
> enabled, but it still breaks.
>
> $ grep -r CONFIG_RETPOLINE .config
> # CONFIG_RETPOLINE is not set
>
> $ grep -r CONFIG_RETPOLINE include/
> include/generated/autoconf.h:#define CONFIG_RETPOLINE 1
> include/config/auto.conf:CONFIG_RETPOLINE=y
>
> So the headers have not been updated yet, maybe?
>

  parent reply	other threads:[~2018-12-05  1:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04  9:58 Compiling with old gcc breaks when CONFIG_RETPOLINE is off Meelis Roos
2018-12-04 13:57 ` Zhenzhong Duan
2018-12-05  1:30 ` Zhenzhong Duan [this message]
2018-12-05  3:00   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f72d5fa-cfed-e1a0-4f6c-90f8d1de1ace@oracle.com \
    --to=zhenzhong.duan@oracle.com \
    --cc=dwmw@amazon.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=tglx@linutronix.de \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).