From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: tglx@linutronix.de, alexios.zavras@intel.com,
gregkh@linuxfoundation.org, allison@lohutok.net,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code
Date: Fri, 3 Jan 2020 13:14:08 +0100 [thread overview]
Message-ID: <3f75dae1-181f-3935-0b1d-40839392226e@samsung.com> (raw)
In-Reply-To: <20190904115406.23880-1-yuehaibing@huawei.com>
On 9/4/19 1:54 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks, patch queued for v5.6 (also sorry for the delay).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/omap2/omapfb/vrfb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/vrfb.c b/drivers/video/fbdev/omap2/omapfb/vrfb.c
> index 819e0bc..ee0dd4c 100644
> --- a/drivers/video/fbdev/omap2/omapfb/vrfb.c
> +++ b/drivers/video/fbdev/omap2/omapfb/vrfb.c
> @@ -339,9 +339,7 @@ static int __init vrfb_probe(struct platform_device *pdev)
> int i;
>
> /* first resource is the register res, the rest are vrfb contexts */
> -
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - vrfb_base = devm_ioremap_resource(&pdev->dev, mem);
> + vrfb_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(vrfb_base))
> return PTR_ERR(vrfb_base);
>
prev parent reply other threads:[~2020-01-03 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190904115507epcas1p42d4d5b2f6ee58db0ccf3b1ee27063ac1@epcas1p4.samsung.com>
2019-09-04 11:54 ` [PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code YueHaibing
2020-01-03 12:14 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f75dae1-181f-3935-0b1d-40839392226e@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).