From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3CD2C47096 for ; Sun, 6 Jun 2021 16:04:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB2D2611C2 for ; Sun, 6 Jun 2021 16:04:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230210AbhFFQGr (ORCPT ); Sun, 6 Jun 2021 12:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbhFFQGo (ORCPT ); Sun, 6 Jun 2021 12:06:44 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2CB1C061766; Sun, 6 Jun 2021 09:04:40 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id r13so8391748wmq.1; Sun, 06 Jun 2021 09:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dps3SYyPvrpPDaumkd4g4ZpYXHif5pvKl1r5pTSaVxo=; b=RFTyE8I7lCbX9/t8ccQmosQTtQ2z07aWs7rWnhtg2w0y/0hF/F8v9tdFufa1GS+vi/ Bf7aOtDV0AnYdcUy0Aidy8c89/g4ozvTxRmBshLbCR04VZ7DpZaGpeP+NWw6Dzwmxj9w J0cfoeiUmhpZe3mNmax/hjq+21Bx9e0TExqUwPcr5hzUBiBwx1ZcPzaaiAKq12NCoeym Z+7YOoGuThBYwfTHDaTflJMBBJqrCiOSTI51vpahatYR2bZBpzIkldGa0c/Jk8TWuyiC IoMtbGSQSUjT6iIcWq6uexcqAfjHtC4/FZQd6tomdF+kGRuuWpNPd8Dv3QmrqSEd2+NJ tq5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dps3SYyPvrpPDaumkd4g4ZpYXHif5pvKl1r5pTSaVxo=; b=k1PnpPHkFCHbyi3F93quXEV4rD5cmTrkQsMZYWaLqdBU/aiZI2jrQhLWk7Ib0r/lnm CsRH1eY5LR3NTAza1OiesV56CNSQvkOZmbrytYdAdaXRfKFw40D/yFxt1pt5y7jRoRGL 9yQO+V/hKpo1afWCo0EpK5vRU0meTTJez70a2V4lkhflfwlF25sf8lY0nfhCal5v7kFd y6ykOKetSQUaS5ssDbNwvQrWELrW+LKJbjT3jPEo2EMxHGIoKAlBtW9ow0Xx/BCCRaGo IXXyYtFea1mZtG20NrX3mTATlHB0QJhGRoDO4s/aIhfIjMWA8vAehVqU6QYT1DVmAUvx HhsQ== X-Gm-Message-State: AOAM531wg560W57IVVL82XtRwj+GuHUMnPCVDIbuRinpXAQ1Vf8YvaHe cRYQGUP4Qyg0EgXMhquR1PrU6APfD/MtsA== X-Google-Smtp-Source: ABdhPJw1zXx5x4rCWVUin281MFlfYrTZRfNIchXpWQrBVFOHppcRsER4RZcjRIUMGQIRr4r6/9EYpA== X-Received: by 2002:a1c:d5:: with SMTP id 204mr12833776wma.144.1622995478819; Sun, 06 Jun 2021 09:04:38 -0700 (PDT) Received: from [192.168.178.196] ([171.33.179.232]) by smtp.gmail.com with ESMTPSA id t4sm13074142wru.53.2021.06.06.09.04.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Jun 2021 09:04:38 -0700 (PDT) Subject: Re: Backporting fix for #199981 to 4.19.y? To: Salvatore Bonaccorso , Greg KH Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org References: <5399984e-0860-170e-377e-1f4bf3ccb3a0@gmail.com> From: =?UTF-8?Q?Lauren=c8=9biu_P=c4=83ncescu?= Message-ID: <3f78a7b2-1b5a-17d2-b862-09fbb53fa409@gmail.com> Date: Sun, 6 Jun 2021 18:04:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Salvatore, Greg, On 6/6/21 2:34 PM, Salvatore Bonaccorso wrote: > Instead of doing a specific backport, maybe it is enough to pick > a46393c02c76 ("ACPI: probe ECDT before loading AML tables regardless > of module-level code flag") frst on 4.19.y and then the mentioned fix > b1c0330823fe ("ACPI: EC: Look for ECDT EC after calling > acpi_load_tables()"). Many thanks for looking into this. I cherry-picked d737f333b211361b6e239fc753b84c3be2634aaa and b1c0330823fe842dbb34641f1410f0afa51c29d3 on linux-4.19.y, they indeed apply cleanly as Salvatore wrote. I also compiled and tested the kernel, the battery is correctly displayed as discharging when unplugged, with a 7.5 hours remaining as expected. Does it still make sense for me to resubmit my patch with the "commit upstream." comment fixed? I would trust upstream more than me making one commit look reasonable while missing the other commit it was based on. Greg, what would you prefer? Best regards, Laurențiu