linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jaswinder Singh" <jaswinderlinux@gmail.com>
To: "Heiko Carstens" <heiko.carstens@de.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Jan Glauber" <jan.glauber@de.ibm.com>
Subject: Re: [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch
Date: Fri, 30 Nov 2007 18:30:45 +0530	[thread overview]
Message-ID: <3f9a31f40711300500h6d13625ua08417ae53acbbea@mail.gmail.com> (raw)
In-Reply-To: <20071130124958.GD11682@osiris.boeblingen.de.ibm.com>

We have two options:

1. Either move arch/s390/crypto/Kconfig to drivers/crypto/Kconfig

OR

2. In arch/s390/crypto/Kconfig , replace "depends on S390" to "depends
on CRYPRO_HW"

I think 2nd option is better for everyone.

Thank you,

Jaswinder Singh.

On 11/30/07, Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> > > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> > > > index 1330061..b699ed5 100644
> > > > --- a/arch/s390/Kconfig
> > > > +++ b/arch/s390/Kconfig
> > > > @@ -537,4 +537,6 @@ source "security/Kconfig"
> > > >
> > > >  source "crypto/Kconfig"
> > > >
> > > > +source "arch/s390/crypto/Kconfig"
> > > > +
> > >
> > > With this there's no dependency on CRYPTO_HW anymore.
> > >
> >
> > Anyhow "if CRYPTO_HW" is not working in drivers/crypto/Kconfig
> >
> > have you tested this patch on S390. Is this giving errors ?
> >
> > And you can also add depends with CRYPTO_HW in arch/s390/crypto/Kconfig
>
> Jan just created a patch which moves everything from
> arch/s390/crypto/Kconfig
> to drivers/crypto/Kconfig. Probably will be merged during the 2.6.25 merge
> window.
>

  reply	other threads:[~2007-11-30 13:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30  8:14 [BUG] 2.6.24-rc3 x86 make depends on s390 arch Jaswinder Singh
2007-11-30 10:37 ` Heiko Carstens
2007-11-30 11:16   ` Jaswinder Singh
2007-11-30 11:03 ` [PATCH] " Jaswinder Singh
2007-11-30 11:50   ` Heiko Carstens
2007-11-30 12:08     ` Jaswinder Singh
2007-11-30 12:49       ` Heiko Carstens
2007-11-30 13:00         ` Jaswinder Singh [this message]
2007-11-30 13:37           ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f9a31f40711300500h6d13625ua08417ae53acbbea@mail.gmail.com \
    --to=jaswinderlinux@gmail.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jan.glauber@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).