From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0162C433F5 for ; Thu, 29 Sep 2022 12:00:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235467AbiI2MAF (ORCPT ); Thu, 29 Sep 2022 08:00:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235502AbiI2L7z (ORCPT ); Thu, 29 Sep 2022 07:59:55 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E8A11055C for ; Thu, 29 Sep 2022 04:59:53 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id bq9so1826950wrb.4 for ; Thu, 29 Sep 2022 04:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date; bh=dUJSDU18CYMRaGiSwsSx0be26VdLB2sB4pmCGCZ1IG8=; b=gfZLQB37F/ECpiUTEE8nEiJ2ocsiIimYEgyMYu3pK6czkZ5QdczYpdFtLKhvfvhvOz Tn6T3q8mjioWtK17djtkQuE7zbz7j5h9rrdNk9L/sw/Il0sZ3ixTBx6Q7dOWLb9siC1/ hP76CTuydLQuQ/bIzpRWqnCjCuMuMxFUzhNAiuQQHWK110LYZld6UOw9/xetGEA0GiRm avaKhLDoVAPfezd3dNoJopyRkwPc8tT3nobuLnATM/ikj3dj1hFlA5SxcBUqrjtXJU/T 7Q7ZAPFj2Ijgs51r+mQ20RoRVa7ULENXM9zsw+gDhY0JWwSQsY8ZvfsrJ67IQ9rLuqSh rHMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=dUJSDU18CYMRaGiSwsSx0be26VdLB2sB4pmCGCZ1IG8=; b=ms+2A6nhPk5Hu+51QU5/+zZSu2gZWkLV4cBhONJvVlHsUd0Q92jZriLof28NcF51T3 rwYOujFydleEAvwkPWahd//EdtMLkTqmrpLCXdv2ddMwzfdrvf/RlewIuroFzMCe4nVp vdPAcO7K2kpLN9v9SHf6HQ4rqf5/0l3CyTuQ7uWjMtccxAb8d/+c3x/f9nMRAQ3eyVWV 5cCmhuirmPdSGsiKslx69WhcByOuQRqgBhnINLm3DKzNZChrXMpoVRsOjWrccMzEdQbo M9+T2Afdx7Q+7Qa6FKVCNlrDmedU1FIKoENC6ioBkpZyrG/aSGwP28B/TEmCDHwzt1VD stxA== X-Gm-Message-State: ACrzQf3Qb8OZ17muLr3w8YkaZPRjLrV+YV1qnw8aYCZNoFRU4AsOcn3V VRrZjd0aPgKf6AS5afapfrMMmw== X-Google-Smtp-Source: AMsMyM5cAPD48p7fBfvz6VufLlQU5vLDMODK8UJznutNylTtmYB0V/mkXII3h//CZtHgtgBAo11pvA== X-Received: by 2002:adf:f482:0:b0:22c:c0f3:f067 with SMTP id l2-20020adff482000000b0022cc0f3f067mr1953249wro.517.1664452791959; Thu, 29 Sep 2022 04:59:51 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:1f17:3ea3:4e46:dff? ([2a01:e0a:982:cbb0:1f17:3ea3:4e46:dff]) by smtp.gmail.com with ESMTPSA id iv16-20020a05600c549000b003b4c40378casm4673941wmb.39.2022.09.29.04.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 04:59:51 -0700 (PDT) Message-ID: <3fa19362-118b-232e-0baf-ee365fa2f2e2@linaro.org> Date: Thu, 29 Sep 2022 13:59:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 5/7] arm: dts: qcom: mdm9615: remove invalid pmic subnodes compatibles Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring , Konrad Dybcio Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20220928-mdm9615-dt-schema-fixes-v1-0-b6e63a7df1e8@linaro.org> <20220928-mdm9615-dt-schema-fixes-v1-5-b6e63a7df1e8@linaro.org> <0636d53f-508f-8a86-0973-2641c9020622@linaro.org> <6ed642ea-424d-49ed-eb30-e09588720373@linaro.org> <1a3c6766-9be5-1e55-95eb-bc9656e5c9a3@linaro.org> <7f8572ab-ff97-54bd-a5f3-fe0e179ee48e@linaro.org> <84cb8941-eb15-1bbf-59b7-bbcd6c15c30d@linaro.org> <07405d0d-8534-6470-21d1-26b85dbd7de0@linaro.org> Reply-To: neil.armstrong@linaro.org From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2022 13:47, Krzysztof Kozlowski wrote: > On 29/09/2022 13:39, Neil Armstrong wrote: >>>>> The DTS looks correct unless you have some real argument that it is not. >>>>> >>>>> How this should be fixed? First, drop bogus entries from drivers, then >>>>> document proper compatibles. >>>> >>>> What do you mean ? There's no point to keep the PM8921 compatibles, the gpio >>> >>> I asked at beginning - why? Why there is no point to keep them? >> >> Because the HW is an PM8018 and the addition of the PM8921 was for policy/organization/struggling-to-make-dt-merged-before-clear-dt-policy/... >> so you say I should modify the Bindings to reflect the actual "pm8018", "pm8921" situation instead of changing the DT even if incorrect ? > > Yes, this is what I already wrote: > > "How this should be fixed? First, drop bogus entries from drivers, then > document proper compatibles." > >>>> and PMIC bindings already enforces to only have the PM8018 compatible. >>> >>> That is just partial argument because binding does not match DTS. So >>> something is not correct. Why do you assume bindings are correct? >> >> Because bindings accurately reflects HW and DT doesn't. > > That's not really an answer... Bindings are correct because they are > correct? What is exactly correct in the bindings? How they reflect the > HW in a proper way, while DTS does not? > > Or let's focus on actual hardware - what are the properties of the > hardware which indicate that DTS is wrong? The actual PMIC is an PM8018 > > Best regards, > Krzysztof > Neil