From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751196AbeAVQiE (ORCPT ); Mon, 22 Jan 2018 11:38:04 -0500 Received: from 9pmail.ess.barracuda.com ([64.235.150.225]:36622 "EHLO 9pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbeAVQiC (ORCPT ); Mon, 22 Jan 2018 11:38:02 -0500 Subject: Re: [PATCH 02/14] MIPS: memblock: Surely map BSS kernel memory section To: Serge Semin , , , , , , , , , CC: , , , , , , , References: <20180117222312.14763-1-fancer.lancer@gmail.com> <20180117222312.14763-3-fancer.lancer@gmail.com> From: Matt Redfearn Message-ID: <3fbb8850-bf34-d698-299a-f1cd62d063ae@mips.com> Date: Mon, 22 Jan 2018 16:35:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180117222312.14763-3-fancer.lancer@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.150.130.83] X-BESS-ID: 1516638949-298552-15526-785-14 X-BESS-VER: 2017.17-r1801171719 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.189240 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Serge, On 17/01/18 22:23, Serge Semin wrote: > The current MIPS code makes sure the kernel code/data/init > sections are in the maps, but BSS should also be there. Quite right - it should. But this was protected against by reserving all bootmem up to the _end symbol here: http://elixir.free-electrons.com/linux/v4.15-rc8/source/arch/mips/kernel/setup.c#L388 Which you remove in the next patch in this series. I'm not sure it is worth disentangling the reserved_end stuff from the next patch to make this into a single logical change of reserving just .bss rather than everything below _end. Reviewed-by: Matt Redfearn Thanks, Matt > > Signed-off-by: Serge Semin > --- > arch/mips/kernel/setup.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > index 76e9e2075..0d21c9e04 100644 > --- a/arch/mips/kernel/setup.c > +++ b/arch/mips/kernel/setup.c > @@ -845,6 +845,9 @@ static void __init arch_mem_init(char **cmdline_p) > arch_mem_addpart(PFN_UP(__pa_symbol(&__init_begin)) << PAGE_SHIFT, > PFN_DOWN(__pa_symbol(&__init_end)) << PAGE_SHIFT, > BOOT_MEM_INIT_RAM); > + arch_mem_addpart(PFN_DOWN(__pa_symbol(&__bss_start)) << PAGE_SHIFT, > + PFN_UP(__pa_symbol(&__bss_stop)) << PAGE_SHIFT, > + BOOT_MEM_RAM); > > pr_info("Determined physical RAM map:\n"); > print_memory_map(); >