From: Randy Dunlap <rdunlap@infradead.org>
To: Oded Gabbay <oded.gabbay@gmail.com>,
linux-kernel@vger.kernel.org, oshpigelman@habana.ai,
ttayar@habana.ai
Cc: gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/5] habanalabs: Add INFO IOCTL opcode for time sync information
Date: Sat, 18 Apr 2020 08:31:26 -0700 [thread overview]
Message-ID: <3fcee921-3eba-b7e7-8adf-d95db9aeeed2@infradead.org> (raw)
In-Reply-To: <20200418082440.21277-1-oded.gabbay@gmail.com>
On 4/18/20 1:24 AM, Oded Gabbay wrote:
> From: Tomer Tayar <ttayar@habana.ai>
>
> Add a new opcode to the INFO IOCTL that retrieves the device time
> alongside the host time, to allow a user application that want to measure
> device time together with host time (such as a profiler) to synchronize
> these times.
>
> Signed-off-by: Tomer Tayar <ttayar@habana.ai>
> Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
> ---
> drivers/misc/habanalabs/goya/goya.c | 10 +++-
> drivers/misc/habanalabs/goya/goyaP.h | 1 +
> drivers/misc/habanalabs/habanalabs.h | 2 +
> drivers/misc/habanalabs/habanalabs_ioctl.c | 19 +++++++
> .../include/goya/asic_reg/goya_regs.h | 1 +
> .../goya/asic_reg/psoc_timestamp_regs.h | 56 +++++++++++++++++++
> include/uapi/misc/habanalabs.h | 8 +++
> 7 files changed, 96 insertions(+), 1 deletion(-)
> create mode 100644 drivers/misc/habanalabs/include/goya/asic_reg/psoc_timestamp_regs.h
Hi,
Not a comment about this patch per se, but ioctls (main number, 'H' in this case)
should be documented in Documentation/userspace-api/ioctl/ioctl-number.rst.
thanks.
--
~Randy
next prev parent reply other threads:[~2020-04-18 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 8:24 [PATCH 1/5] habanalabs: Add INFO IOCTL opcode for time sync information Oded Gabbay
2020-04-18 8:24 ` [PATCH 2/5] habanalabs: Allow access to TPC LFSR register Oded Gabbay
2020-04-18 8:24 ` [PATCH 3/5] habanalabs: Align protection bits configuration of all TPCs Oded Gabbay
2020-04-18 8:24 ` [PATCH 4/5] habanalabs: support hwmon_reset_history attribute Oded Gabbay
2020-04-18 8:24 ` [PATCH 5/5] habanalabs: leave space for 2xMSG_PROT in CB Oded Gabbay
2020-04-19 6:14 ` Tomer Tayar
2020-04-18 15:31 ` Randy Dunlap [this message]
2020-04-18 17:17 ` [PATCH 1/5] habanalabs: Add INFO IOCTL opcode for time sync information Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fcee921-3eba-b7e7-8adf-d95db9aeeed2@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@gmail.com \
--cc=oshpigelman@habana.ai \
--cc=ttayar@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).