From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752206AbdBBSMm (ORCPT ); Thu, 2 Feb 2017 13:12:42 -0500 Received: from mail-ve1eur01on0045.outbound.protection.outlook.com ([104.47.1.45]:17057 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751298AbdBBSMk (ORCPT ); Thu, 2 Feb 2017 13:12:40 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@mellanox.com; Subject: Re: [PATCH v15 04/13] task_isolation: add initial support To: Eugene Syromiatnikov , References: <1471382376-5443-5-git-send-email-cmetcalf@mellanox.com> <20170202161338.GA31779@asgard.redhat.com> CC: Frederic Weisbecker From: Chris Metcalf Message-ID: <3fd6fcf2-e31c-7623-a52b-927ade68e2b2@mellanox.com> Date: Thu, 2 Feb 2017 13:12:27 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170202161338.GA31779@asgard.redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: MWHPR05CA0017.namprd05.prod.outlook.com (10.168.242.155) To DB6PR0501MB2757.eurprd05.prod.outlook.com (10.172.226.9) X-MS-Office365-Filtering-Correlation-Id: 2dc3acd6-1e99-42e1-6c9e-08d44b9711b3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:DB6PR0501MB2757; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0501MB2757;3:gKrFsj4w+xRHbwAld/dPFUC8yee27NWSQ/mnywaFH5m4OwD1ch05lEiOYdw9s2oOG/N6gyJvgFs2qg27MBtcdS7GvHKrro8dZCQUk0NQj9l1NP5JNGQvRrF03Dgs2oHNVlvSkZmKTInZdJPmSY2kILjnk4Q7A4/DubOpUZhDT+MhscJEiBJA00a5y8B4sj1kiqXND64I9PBwYIX5enAXu8RUmTfL1Ts/tEnK9q0plyTmQeJsxYcdVIiqPejL+ZfWsLWH+LFFgVTNN1/rY7wgtMN1JlhnjAdl/rsM3cwGra0=;25:D/3VoWpN71HG5lCuPbAdk7T04irHZfjj5qLJzXrs2D1eeRvZRSlo4iAaZ6Hhk6zG3w2ArFYhm+XhVyEjSuXWjVss2yBH3B2s5jHhJfC0XJyVsmETkQR6N2zMUvix9H1hHRxDOlGA2TDXXcBb1YhNTRAhsZABnXhlmqP+S716fdkAlOEL/IY93bYaB+lcU/57EJYz5gZtGScApc3A/9BveD/i6Uea9kUE+IjOJfA0rkqV3VexIp2055cQU8aannBuOdwF/g0TXQXzfwTCB7XkuoU70RrAa9NHhaCx5vb7asDu6CF8QduD8uMABl7EU0OTVYrxbkEHobSkMrCO4JJqcKwf4bNDkwSN4kGx1b6sNq/PL6IN1fnGc8Xh5Bx/SxZAdT0k+q6mW9jhL/2PRKDV7WSxCYgIXhuxbeBKjr+J1GkGc9r6LRkzvga577r8coPV2pyTg8jKts+BPM8EtxqEqA== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0501MB2757;31:9DUkFUzPt2oxuTrcJngMaEomSXd6SGJLZ3Ap6f5+SZuVSg0RKgUhm2QRktJMfUHSer1pfPXAeMnFj70Nqm8Cwtnpozm0bWqdhElRo22+TlwAu0+RoqOY0vQVPgq4bhFI4AAtMewNMViO9Vx7FqNcPQD5WBP9zXr+fNOCl7dM2gMYODhYVNIYzZbYOlYY8/j7JhIL3kEihkr1fZ3eQ6ICFuZZJu0TBjhspQ9bkqBYKNuREjhb3qh6Rqbp/uu+AnZfblKPx5iUQFyWdRGL7hFzdA==;20:NmcvnpJePraoQdzenVsiFsl0jZL9lISEO02SWOOPXrBK0RWj5Yq51yBRqGxUIHUNBIpmTj+M0fcDytudGFsWZrCDjArMvy9mRnCyyj0pW/elHOCTC2Bj7YLsTAOhPjceTHlfkoLGCVgZzARbV3XWN5Oqq9TCAMyfrdVwh1/g3Pl9euxJF2LnIVu5G2elGO/u/shkyK3HyKYl3IPvUsH0+Iz5pzDHViJ27dmieGyY5aLpoUqe9opEa3JiSivRLV9RCJV3NFFAAklqX54xbDDVSTOtVnSch0UkKKT8TpTO4EqB7Ce5LPCHB4wZ/+SEGhnVGjAVIqvE7D6c4Fr5fXcvjrUQa5g79jnV9hv5PJmYXlK6L8Z9ntswUL/7IsjW7bFiGLrKBXF1qw8zAed5HN9OWR+/cLKTwGk9lfQElPBq/LIRe/KDKd5p7BvSP93esAIh2dz+vSc/ZYD3XhKBpjsdAnuA6W7Ala5QVNiJp++73j51t7A8L56sr5ExuKqO9koi X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(171992500451332); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558025)(6072148);SRVR:DB6PR0501MB2757;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0501MB2757; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0501MB2757;4:3kBG4sj/Vt2eKHa7oaDljR1Df1FHN+DQMc9BSfhWQ4YbG74smqBz3qLESmplsIA38h6xozc+VXPNt8hre0eycF4nlkmJuj+419oZDWNQLaZp2SvXiks4E4ux3x7Zgwvfa4k/owaGWRCNYFBXRA8RB7bb6IH7LpWOwrILWX2Xp4eZcDdBEOy7pOMfndeXKNq+y0wGdn2V9Xn11bffuDCJksiaMUHPYgzVLGv6n1VTROyZKWogNal8KK9wlMSqEsiBI0dWnef4yV+m9gJsGZWvHJhgRGbAY1Z4159F8JJqHST7osJMpcDw98NoJTzThPYbGzYlkQto8npTtptqv3uMRcXowZCeaiH8rabEM1GlDjwk3RII7IVuU0aVf+YYM2EDznPij1Soxt5c1LwrrrDw/Qf6JzmEoy7xvQ+A7REtAgHefHggoh5ljOY0HTxtVXW81/XMuUZ3zd3pG8pcGDY7HGLREdlWSJ0W/Cd7o5jzsGE8FYDkVi5mbqazKWB5FvPrzcbeVjiQjYq577Z7a8PDCdHcZYFsONNzWjjii0RbAh0OgQJL7yN495x8QeRKO2LitXC5QOeaZNi1lYXb1G73nFpFgptztBt4E3z5HrB0A1BO8+9Z4jdxotd7E1rpQrFwLfjkzYmJHH5wtgmXDS2PRSHd1yBtOR7AsLvMivMb0N0= X-Forefront-PRVS: 02065A9E77 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(39840400002)(39410400002)(39850400002)(39450400003)(24454002)(189002)(199003)(377454003)(2950100002)(53936002)(50466002)(92566002)(2906002)(966004)(31686004)(101416001)(305945005)(4326007)(42186005)(36756003)(83506001)(8676002)(33646002)(81166006)(230700001)(6116002)(7736002)(81156014)(106356001)(86362001)(229853002)(77096006)(6666003)(65806001)(66066001)(23746002)(65956001)(6306002)(68736007)(6486002)(3846002)(25786008)(90366009)(31696002)(65826007)(54356999)(76176999)(5660300001)(64126003)(38730400001)(39060400001)(189998001)(105586002)(47776003)(5001770100001)(4001350100001)(97736004)(50986999)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0501MB2757;H:[10.15.7.185];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB6PR0501MB2757;23:X1r/pzW3Mkbdzop0Fw6N4zLnmq/esL0OBOK?= =?Windows-1252?Q?DZbJTr+0qgrcsr6Zo1MpMFCBNmtAtVxZDMvJghLODvpT7qasy8Ji7rUy?= =?Windows-1252?Q?SXtSYosQFR3UErSKTVGsqZtRQVY6xPA93I0Zfm7KLk+HCBZnmkRSbS8r?= =?Windows-1252?Q?DtPd2Nzcbcj0hPDgd8hFFfwR0s3RCWxQnvHMe8tRNoTJymJRHWFifRHO?= =?Windows-1252?Q?sp5ZDoFGKZ/rKm89RH8McC6SdeADfs6fdknPRiX1UL6pL3VTUBRztbgq?= =?Windows-1252?Q?qxLoHxL1SU92gSgjZetllELmPAnQDUtbkTW/+lexMrYkJGGr5klSnH9b?= =?Windows-1252?Q?ud2vc4y76OWQWKy52fOPSxKHahTq2u7h/n3kc4PaMUnRI7EvZt985Z+A?= =?Windows-1252?Q?trxJynVeD32zJCaXaA7as55dViSlstZGcnpmaUVkV5xQFDwNX0is6f+/?= =?Windows-1252?Q?XVlzkDt4fLmmzNsCwENCsAt9yHakFSouhyD7/s1PsQDeF0E1Bss1PGg+?= =?Windows-1252?Q?D8KEq1IRnMhrfBRKfjC4eQ1WC8v6g8K57/Wtrrrp9+w8DLq+Am1XPzcE?= =?Windows-1252?Q?SKkK6PA6cRaTBlTvu33P4ctO0AG0IHUhHXwCmLB2PYG8+Jvbl75q/5nu?= =?Windows-1252?Q?8rMZ45TFIjMYNOVCNZPw8MFFogJaRq0PF2PKieqzazgsuVuos3BUaeGu?= =?Windows-1252?Q?IGRA9TA5xfxXryLrpty0bzdLtb0ERBhL7CaUPrFGhkTPvhKm55O+ptq9?= =?Windows-1252?Q?+31AKnilZduWyO2bzNSxhiNEqr4xwDE1hWmL6PK5NoVCmPFLqkcMwX/n?= =?Windows-1252?Q?K/nwo3bhAqtd74ZtF3OC3n3UwGG23aWT2GweP+RWY1mTqoEuywV1SZCl?= =?Windows-1252?Q?7xDJvBI+cwCvXp9mAamjqhbUdc2yiv4IEYgPKGONFukPR+E3LkcBdQV3?= =?Windows-1252?Q?lwltXN+UepP9YqSSlBHypD5P7md6jRLxS+MY6OEyI0yR96sKORH72PN9?= =?Windows-1252?Q?XUdjoNuAtI9A2YPwnRqpkckkvXrWOwmtVQv+83pMZXrqZoQBRm82bjKg?= =?Windows-1252?Q?m5GmX8vwfrH9pKB5bNlWi8SlDQjhwD07EahzpaRL/ZYcP0tkGhhRlHzX?= =?Windows-1252?Q?EVmVJJPEKWZSerHEtn1ndLmU/Zd8cFrzt/vqGKZuoL6JY7ODoX8R//N2?= =?Windows-1252?Q?xAKfzcH5kwOT/JVCcVdMAU7yGmkhwf9bxF9aDYaTMUexCjs22zjlePRK?= =?Windows-1252?Q?9RY08xxnPdwF9SknRWZ36QgjnfHA8W4EKwhKbLJqzrmOgWWR9kEBdE2r?= =?Windows-1252?Q?1giu2U11JEiJZzk0LVUDpmAFri5XXeaaV4vDTxLBGTCqpC0ss12LgGmH?= =?Windows-1252?Q?6DjmsYAG548g14wHfYKU+6jTZpt2SSGS55QkvziAF0xKUzEL4qyDtW4F?= =?Windows-1252?Q?WAYE7ACID0Iz5Ei/Fzc9irLHabrA1tkpI1aRode5MBCWrumO1nuN2Ca0?= =?Windows-1252?Q?NJX73+ZUKYfFcP11uQFTRLkYM7mIiHSufky6PHNxlNJ2n0gM+OzxZ6Y7?= =?Windows-1252?Q?dNF7AUSiqGkaHGsIG8CMScE/W2ZUvSVlbtpdXOsn/9xamq1F6/OmEaR9?= =?Windows-1252?Q?2EFoGp9DZ0Euu8cof1dk2aT9xDHPrXHGgkU8Uqo/0BCPg?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0501MB2757;6:JpjN9GzljGElE/yMNqREfNnB2WB6oNxOwSA+vQUb4VdxaWvt4h88ZW6UJcvG1u47QMMN1MfCeb2NVLxOdl4xED9HmVN0LrhPbVIjWbOYvthc0GWlwLZZMvSZSorQ+XjIY7N121X+2Hzg2E6AOoYOmYlTDFhsdD2Q05qRZi4gzY4Q8yKD4ssRsaVkiLBhWJb0rt2UasPyvfdSjjbnRv0wtQT4kX4qUmzVF12mbFf8Nsl8gm1Y2RkCcbgcAJydiGssiAbA09ij+NV4PeUe6Nau4NOphFzPiau4wO8ccF0WC92t4JXehkOH8XyEKwqSupqaWm2fkPb0xN2UMDRadaUzm1wGZKVb+RCkbZRpP7fwIbMWCR/cZUR0mFc+jphOBMCTEGWKPAqBS6BwyBA8366+TO1/hLohC3Yjd9TYBUT3MF4NCm3Z39KXDv1YMufMyUT5;5:A5qARquIpkhdxxJacctMvxggvxPwv2aWHSatppZg53drsOQF2tYAv65mP1q8XRNpdW8+0vYs09jMlf3rxAB3l6Pz0off6p2Ph1sYUjqYjJc+yTei3Eq4OFG8UlEyKvDj00VOJV6GtqiMdfxg8Mi8/A==;24:34iGtFUFJnuHoU6srNrtRazCFoDhZtWSp0aF+f0r41xWZvLNFsraF7MZ8Y3p4IhZOIiRJ4G5tYcsAiJiKxywhsZ8XPQ/xHcP+HDwn2GoMFs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0501MB2757;7:8jGuwkHQa1LEY1uaU62twtGvqxySOj4xUxMVk6C6ZiZB0cbmNo/UwPzzKpLM/X7ndnP/VyHq3y3Oo0PIMc1hgqtekTFvuslraOBfbZQF91kEW9QuPoFrF1++oJUa7qseynTehtO7/ObY7cOe1HnHWWCHIxWtTjlBkzfCQJW80NDs9CEqr+CRQAEt1KNDI9KL1m4qhThcfJ9dR4HrdsRsgEM0Xnfinq+Ahs2JZW4VM4bGcwR5Ty4mxLcu/6T2QT8RVEAxruKW3Imx0LYCQ90Zz1KDbPpAvZnFJvMyiqLnB4lwOzVrTbhB8+Ov6vlIlD8cNG+LwXMr0m+zgdrkBk7ABni9iei09TGUeA+s8S88Fji1v3J9i+3ASxp46fW00RTwWGEqGtoTZcm1ooVfmu9Pj9mN0v8sJTwq0uFkCFL/lvOBERsI0CEfvMSxAKNOwUHh2TMnt7Ha5G+OtTdd4Q+Mv2IPg5/EI/twfMnVhrOo68kbpa7UUt3fDM0RIFldfuswbgUNZK09zcTRjq0XSuOIkxHvMPCvb2K+91qOcmh7psQd1P2ETPyXL97jWezyoJno X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2017 18:12:36.3969 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2757 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/2/2017 11:13 AM, Eugene Syromiatnikov wrote: >> case PR_GET_FP_MODE: >> error = GET_FP_MODE(me); >> break; >> +#ifdef CONFIG_TASK_ISOLATION >> + case PR_SET_TASK_ISOLATION: >> + error = task_isolation_set(arg2); >> + break; >> + case PR_GET_TASK_ISOLATION: >> + error = me->task_isolation_flags; >> + break; >> +#endif >> default: >> error = -EINVAL; >> break; > It is not a very good idea to ignore the values of unused arguments; it > prevents future their usage, as user space can pass some garbage values > here. Check out the code for newer prctl handlers, like > PR_SET_NO_NEW_PRIVS, PR_SET_THP_DISABLE, or PR_MPX_ENABLE_MANAGEMENT > (PR_[SG]_FP_MODE is an unfortunate recent omission). > > The other thing is the usage of #ifdef's, which is generally avoided > there. Also, the patch for man-pages, describing the new prctl calls, is > missing. Thanks, I appreciate the feedback. I'll fold this into the next spin of the series! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com