From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: samirweng1979 <samirweng1979@163.com>,
davem@davemloft.net, dinghao.liu@zju.edu.cn
Cc: linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
wengjianfeng <wengjianfeng@yulong.com>
Subject: Re: [PATCH] NFC: st95hf: remove unnecessary assignment and label
Date: Tue, 25 May 2021 07:38:12 -0400 [thread overview]
Message-ID: <3fe26970-91ab-d598-92ff-e13d8d707d47@canonical.com> (raw)
In-Reply-To: <20210525063801.11840-1-samirweng1979@163.com>
On 25/05/2021 02:38, samirweng1979 wrote:
> From: wengjianfeng <wengjianfeng@yulong.com>
>
> In function st95hf_in_send_cmd, the variable rc is assigned then goto
> error label, which just return rc, so we use return to replace it. and
s/return/returns/
s/. and/. Since/ (don't start sentences with "and", neither with
lowercase letter).
> error label only used once in the function, so we remove error label.
With these fixes and subject prefix fix to "nfc" (lowercase):
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2021-05-25 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 6:38 [PATCH] NFC: st95hf: remove unnecessary assignment and label samirweng1979
2021-05-25 11:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe26970-91ab-d598-92ff-e13d8d707d47@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=davem@davemloft.net \
--cc=dinghao.liu@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=samirweng1979@163.com \
--cc=wengjianfeng@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).