From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 500DEC433E1 for ; Thu, 27 Aug 2020 14:33:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24DE92087D for ; Thu, 27 Aug 2020 14:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727069AbgH0OdR (ORCPT ); Thu, 27 Aug 2020 10:33:17 -0400 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:45168 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727913AbgH0O3I (ORCPT ); Thu, 27 Aug 2020 10:29:08 -0400 Received: from [78.134.86.56] (port=42726 helo=[192.168.77.62]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kBItY-0004dO-C9; Thu, 27 Aug 2020 16:28:52 +0200 Subject: Re: [PATCH 1/3] fpga manager: xilinx-spi: remove stray comment To: Moritz Fischer Cc: linux-fpga@vger.kernel.org, Tom Rix , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anatolij Gustschin References: <20200817165911.32589-1-luca@lucaceresoli.net> <20200820041110.GA4022@epycbox.lan> From: Luca Ceresoli Message-ID: <3fe28140-0ea1-90a1-d5a0-1ca5fa83cb8e@lucaceresoli.net> Date: Thu, 27 Aug 2020 16:28:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200820041110.GA4022@epycbox.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Moritz, On 20/08/20 06:11, Moritz Fischer wrote: > On Mon, Aug 17, 2020 at 06:59:09PM +0200, Luca Ceresoli wrote: >> Remove comment committed by mistake. >> >> Fixes: dd2784c01d93 ("fpga manager: xilinx-spi: check INIT_B pin during write_init") >> Signed-off-by: Luca Ceresoli >> --- >> drivers/fpga/xilinx-spi.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c >> index 2967aa2a74e2..502fae0d1d85 100644 >> --- a/drivers/fpga/xilinx-spi.c >> +++ b/drivers/fpga/xilinx-spi.c >> @@ -57,7 +57,6 @@ static int wait_for_init_b(struct fpga_manager *mgr, int value, >> >> if (conf->init_b) { >> while (time_before(jiffies, timeout)) { >> - /* dump_state(conf, "wait for init_d .."); */ >> if (gpiod_get_value(conf->init_b) == value) >> return 0; >> usleep_range(100, 400); >> -- >> 2.28.0 >> > > Applied to for-next, > > Thanks > Thanks, but still I don't see it. Missing push? As I'm sending a v2 patch series, I'll keep this patch for now, just in case. -- Luca