From: Mike Galbraith <efault@gmx.de>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"bsegall@google.com" <bsegall@google.com>,
"mgorman@suse.de" <mgorman@suse.de>
Cc: "valentin.schneider@arm.com" <valentin.schneider@arm.com>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"bristot@redhat.com" <bristot@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xuwei (O)" <xuwei5@huawei.com>,
"Zengtao (B)" <prime.zeng@hisilicon.com>,
"guodong.xu@linaro.org" <guodong.xu@linaro.org>,
yangyicong <yangyicong@huawei.com>,
"Liguozhu (Kenneth)" <liguozhu@hisilicon.com>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>,
wanghuiqiang <wanghuiqiang@huawei.com>,
"xieyongjia (A)" <xieyongjia1@huawei.com>
Subject: Re: [PATCH] sched/fair: don't use waker's cpu if the waker of sync wake-up is interrupt
Date: Tue, 27 Apr 2021 07:54:32 +0200 [thread overview]
Message-ID: <3fe7113cc87ac89077b55ca55bda2b99729f13c8.camel@gmx.de> (raw)
In-Reply-To: <d057eb13ec4e4643b314dd1652ffa9d4@hisilicon.com>
On Tue, 2021-04-27 at 04:44 +0000, Song Bao Hua (Barry Song) wrote:
>
>
> I agree sync hint might have been overused by other kernel subsystem.
> But this patch will at least fix a case: sync waker is interrupt,
> in this case, the existing task has nothing to do with waker and wakee,
> so this case should be excluded from wake_affine_idle().
I long ago tried filtering interrupt wakeups, and met some surprises.
Wakeup twiddling always managing to end up being a rob Peter to pay
Paul operation despite our best efforts, here's hoping that your pile
of stolen cycles is small enough to escape performance bot notice :)
-Mike
next prev parent reply other threads:[~2021-04-27 5:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 2:37 [PATCH] sched/fair: don't use waker's cpu if the waker of sync wake-up is interrupt Barry Song
2021-04-27 4:21 ` Mike Galbraith
2021-04-27 4:44 ` Song Bao Hua (Barry Song)
2021-04-27 5:54 ` Mike Galbraith [this message]
2021-04-27 6:05 ` Song Bao Hua (Barry Song)
2021-04-27 6:15 ` Mike Galbraith
2021-05-05 13:19 ` [sched/fair] 5f94d1b650: stress-ng.sock.ops_per_sec -25.2% regression kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe7113cc87ac89077b55ca55bda2b99729f13c8.camel@gmx.de \
--to=efault@gmx.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=guodong.xu@linaro.org \
--cc=juri.lelli@redhat.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@hisilicon.com \
--cc=rostedt@goodmis.org \
--cc=song.bao.hua@hisilicon.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=wanghuiqiang@huawei.com \
--cc=xieyongjia1@huawei.com \
--cc=xuwei5@huawei.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).