linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com>
To: Richard Neumann <mail@richard-neumann.de>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Sandeep Singh <Sandeep.Singh@amd.com>,
	Shyam-sundar.S-k@amd.com, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-input <linux-input@vger.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jonathan Cameron <jic23@kernel.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v4 2/4] SFH: PCI driver to add support of AMD sensor fusion Hub using HID framework
Date: Mon, 6 Apr 2020 10:56:33 +0530	[thread overview]
Message-ID: <3ffc343e-c44b-1b4e-993e-179a13dc928c@amd.com> (raw)
In-Reply-To: <9aea760f9abdd2f90f36642af77de7bfae719485.camel@richard-neumann.de>

HI

On 4/1/2020 9:58 PM, Richard Neumann wrote:
> Am Dienstag, den 31.03.2020, 20:24 +0300 schrieb Andy Shevchenko:
>> On Tue, Mar 31, 2020 at 4:26 PM Shah, Nehal-bakulchandra
>> <nehal-bakulchandra.shah@amd.com> wrote:
>>> On 3/31/2020 6:01 PM, Richard Neumann wrote:
>>>> Not a real review, but your patch series seems to be repeating a
>>>> lot
>>>> from drivers/i2c/busses/i2c-amd-mp2*.
>>>> Is there any chance we could re-use the code?
>>>> E.g. the AMD_C2P_* definitions from drivers/i2c/busses/i2c-amd-
>>>> mp2.h?
>>> Thanks for the mail. Yes there are some common structures, however
>>> as of now we have kept separately considering both
>>>
>>> are part of different sub systems. But may be will consider this
>>> input for future enhancement.
>> It can be done in a form of shared definitions at least in
>> include/linux/platform_data/x86/amd-mp2.h or alike ...
>>
> I managed to add support for the AMD SFH PCI device to i2c-amd-mp2* and
> outsourced the headers to include/linux/i2c-amd-mp2.h. [1]
> I also refactored the patch series (excluded the documentation) [2] to
> use the PCI device now provided by i2c_amd_mp2_pci and removed some
> duplicate and unncessary code.
> The driver now consist of just one module (amd_sfhtp_hid).
> Unfortunately I was not able to solve the problem, that I get AMD-Vi
> IO_PAGE_FAULT errors when not booted with amd_iommu=off.
>
> [1] https://gist.githubusercontent.com/conqp/4d726f86da8a8397d6e70091a124de67/raw/f97e88a0b44d98bfa1258cb73c8afe4dce7afa87/i2c-amd-mp2.patch
> [2] https://gist.githubusercontent.com/conqp/67036e690aca89d08b958971edac283d/raw/2a1ef122f9c8c8e07164b6d597962ce7bbad6d45/amd-sfhtp.patch

Thanks for the patch and appreciate your efforts. At this point of time, we would like to have our first patch for SFH to be upstreamed and dont want to complicate the

with two sub systems and maintainers. Surely will consider this input for future enhancement. Thanks for your understanding.

Thanks


Nehal



  reply	other threads:[~2020-04-06  5:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27  4:58 [PATCH v4 0/4] SFH: Add Support for AMD Sensor Fusion Hub Sandeep Singh
2020-02-27  4:58 ` [PATCH v4 1/4] SFH: Add maintainers and documentation for AMD SFH based on HID framework Sandeep Singh
2020-02-27  4:58 ` [PATCH v4 2/4] SFH: PCI driver to add support of AMD sensor fusion Hub using " Sandeep Singh
2020-03-09  5:13   ` Singh, Sandeep
2020-03-27 14:55   ` Andy Shevchenko
2020-03-30  5:12     ` Singh, Sandeep
2020-03-30  8:33   ` Richard Neumann
2020-03-31 12:31   ` Richard Neumann
2020-03-31 13:18     ` Shah, Nehal-bakulchandra
2020-03-31 17:24       ` Andy Shevchenko
2020-04-01 16:28         ` Richard Neumann
2020-04-06  5:26           ` Shah, Nehal-bakulchandra [this message]
2020-04-13 13:33             ` Richard Neumann
2020-04-21 18:31               ` Shah, Nehal-bakulchandra
2020-04-21 21:18                 ` Richard Neumann
2020-02-27  4:58 ` [PATCH v4 3/4] SFH: Transport Driver to add support of AMD Sensor Fusion Hub (SFH) Sandeep Singh
2020-02-27  4:58 ` [PATCH v4 4/4] SFH: Create HID report to Enable support of AMD sensor fusion " Sandeep Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ffc343e-c44b-1b4e-993e-179a13dc928c@amd.com \
    --to=nehal-bakulchandra.shah@amd.com \
    --cc=Sandeep.Singh@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=jic23@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@richard-neumann.de \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).