From: Paolo Bonzini <pbonzini@redhat.com>
To: Chen Zhou <chenzhou10@huawei.com>,
rkrcmar@redhat.com, tglx@linutronix.de, mingo@redhat.com
Cc: hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: SVM: fix error return code in svm_create_vcpu()
Date: Tue, 17 Nov 2020 08:40:06 +0100 [thread overview]
Message-ID: <3ffc3a59-fdc1-3cb4-46e8-0369084bcc06@redhat.com> (raw)
In-Reply-To: <20201117025426.167824-1-chenzhou10@huawei.com>
On 17/11/20 03:54, Chen Zhou wrote:
> Fix to return a negative error code from the error handling case
> instead of 0 in function svm_create_vcpu(), as done elsewhere in this
> function.
>
> Fixes: f4c847a95654 ("KVM: SVM: refactor msr permission bitmap allocation")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> arch/x86/kvm/svm/svm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index 1e81cfebd491..79b3a564f1c9 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -1309,8 +1309,10 @@ static int svm_create_vcpu(struct kvm_vcpu *vcpu)
> svm->avic_is_running = true;
>
> svm->msrpm = svm_vcpu_alloc_msrpm();
> - if (!svm->msrpm)
> + if (!svm->msrpm) {
> + err = -ENOMEM;
> goto error_free_vmcb_page;
> + }
>
> svm_vcpu_init_msrpm(vcpu, svm->msrpm);
>
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-11-17 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 2:54 [PATCH] KVM: SVM: fix error return code in svm_create_vcpu() Chen Zhou
2020-11-17 7:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ffc3a59-fdc1-3cb4-46e8-0369084bcc06@redhat.com \
--to=pbonzini@redhat.com \
--cc=chenzhou10@huawei.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).